From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756445AbdKCUBQ (ORCPT ); Fri, 3 Nov 2017 16:01:16 -0400 Received: from mail-bn3nam01on0067.outbound.protection.outlook.com ([104.47.33.67]:13344 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755868AbdKCUBN (ORCPT ); Fri, 3 Nov 2017 16:01:13 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v7 18/38] crypto: ccp: Implement SEV_PEK_CSR ioctl command To: Borislav Petkov References: <20171101211623.71496-1-brijesh.singh@amd.com> <20171101211623.71496-19-brijesh.singh@amd.com> <20171103194209.epitwoakf3c3qlk5@pd.tnic> From: Brijesh Singh Message-ID: <9ae137d6-dc96-e399-8ea8-cb16b10f9d0b@amd.com> Date: Fri, 3 Nov 2017 15:01:05 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171103194209.epitwoakf3c3qlk5@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR03CA0062.namprd03.prod.outlook.com (10.173.137.24) To SN1PR12MB0157.namprd12.prod.outlook.com (10.162.3.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a6dfe873-81a5-4d73-78aa-08d522f5a13b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:SN1PR12MB0157; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;3:1cZWhf5cQN96so4DDXOKJdOlqR7OcXHSH5J2s9Xt2dw19n3P5U+5+f8FPGqvjBhFBm2mwnqy9UZ7rA9Tph1cLNzXqOZTccAYGS1jC6/skBNV//mqkAF2lpsvX2JEjVJVc5oMR8xbOTODODXYwb0I7mX4DRkFHwkufXcgWC5FHX7wceAYUHF5O7B84MoE16/YK0sB6Y4ysoY/2ckmlaGyjrl3wbCsELBxj/JNJowWaghZkLhQ7OtCB8s3ktFuDYjK;25:ayN/AOrbqCWqBWRHNIgnWZmCp198QSKm0Fw4IycyWd7YTE6rv6SkslbCiIsqy96ZgswcoyDKdBIjsg7SNwZFQsnd6PFEklr5zVodRIQ59drtC2G9Q0G4h4yr7KvVe1bagMNsWF6BeRpKK6unx8bzTh237iprelezfFtqMdFzjbjFP2aqcPvuP6igKrg2pMOHxcYd5E51CsZE8Mu9J1oKTZrczXui+27SLTsM21ydhy1T3omCWn5Y1wXvb3q4WBXGB34YMSfPajXMHA76L0Pb3Iz58Gb/pqSP3dfcrmOcvEtl4+sE6gAJRYxceJG0vztb/pNMMBL+x1+UIOAEnEMq3A==;31:I132zCIlncq0XM+ECsqyLM1EDSh+bMyozjCZ7vBrKAuANntKvAOfbgNEf4LlmB5s9RBJ9CdnKYwJKFeh3tyc8PDu7cBokijVRw51B+mTIck0t6VsAAcn2BzvXUmfmCiR+75MA1Zj6uKhEAk6j8HtFKw9ImZXg/eiu3DIZLD5cq0joY25SGNv/OU3uhePtQG7YtK3MYJ8AZDAzAovqCdRG33C25b7kKQPuE+J4KYB1Bs= X-MS-TrafficTypeDiagnostic: SN1PR12MB0157: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;20:OWALf8iQgwqbJV7S3zXt0UHupF7GsAHKHVrwM9OwbH5+/+C6Ou8gSouWTT2pu0pLgX5E2l4TjoGYKSeyGtMTwP9RQRBHw/QyqpNrjbMD5ORxUlq+Jn+wRXUbVhOabYmVUwG/XEktZv3wuEItKsaEhUP+Dxte9CkxjxOzl0KVjDyL9ElTt7jULlCtLPhvJsfquWsMiGRH6/aANYlEvTPQuHZiDVf5U2vAVgIHwfQJCUdRQ7wV3Uhk4RMUHLSnPXVCgCdw/p3su4xAIliRtssyYXkTXM+jgsZwi/9nu3ER0U6++2JItp89ItkMfInAC2ogm21swOiYehacU9PfUfIMv3IOAxYpcwb28ysNFkqAAZV4NLHniFOSt0nYgw4+7+LXStXSRgpffsWIzGoKRFDrI1/SaDqWzif0ZmOEcwafkag2ujGJ6AxpOXAFlvrXkKeh5XNflKXBDAXMr9tSrgZ/MlLrgHLXz0oGQHi7sW0p6UlH4I1gONEuV+xnqzDV09KU;4:rCQS9+24PZICX79tzmK2OPBoLf5kbiukOxpMUt2o1Po4czUXvd8p1f7q+6/Mo0Fl+yoX504/pMn9HR606sUu8ZHHVlJoDd5KnBEK1kuBiSOpMFH1ELDppq95P0uM1xmrZ6b0y/O/efS30d5BHfkkk9/qKKKIgxG4Xvi0c827sbp8ITKk4o/6MYjyl8AnMGIPnWuzzOf+Bmv1juq4NNVtaxRhgj1NKFAkvIfRc80q5o/13i3li8pielDIbYneUqf1IPIxCXBgjosMrJrzODE2lg== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(3231021)(6055026)(6041248)(20161123558100)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0157;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0157; X-Forefront-PRVS: 0480A51D4A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(376002)(346002)(199003)(24454002)(189002)(16526018)(50986999)(6486002)(81166006)(189998001)(8676002)(31696002)(86362001)(68736007)(316002)(81156014)(229853002)(6116002)(230700001)(3846002)(33646002)(83506002)(64126003)(36756003)(305945005)(53936002)(23676003)(25786009)(4326008)(76176999)(54356999)(101416001)(7736002)(6666003)(6246003)(6916009)(2950100002)(106356001)(50466002)(31686004)(5660300001)(53546010)(65806001)(53416004)(105586002)(478600001)(54906003)(58126008)(66066001)(47776003)(2906002)(97736004)(65956001)(8936002)(65826007);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0157;H:wsp093843wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU3OzIzOmdiRWhKT0FkR0VQQndhVkdNMlFuNGxGMEpD?= =?utf-8?B?R0JtampZNDk5Vk9Xd1R0bUw3Rk5USkYxV2k3TytSQVpMQ3FCbjZzRWJZcTZ1?= =?utf-8?B?WklFZlArb0VKVXc2NUJsdXlaeDdkRkhZeVBuL3Y2Mm1nczk4UmNzTlNOd2hI?= =?utf-8?B?dFdiVmllMlR6ZzJmOVBMbHJxdGtEUXV1UmFmbWxLanFDK09ETzN6VXV6UnA2?= =?utf-8?B?Rkp3NjNXa2Jsc0plbkxraGN4amJST0c4K3Q2aXdXUTdwWWRpRVJZcTBmVi90?= =?utf-8?B?amtYUUtuZG42cWZYdmw0eEZLcXRUSXFFVDUrVFliYVFLZWM3TGNJU2R4cXAw?= =?utf-8?B?aWV5bDJwQWplTHZpcytzUDFncmpheU53cGFCKy9MVlZ4QWg2QUtOZzhTZDB2?= =?utf-8?B?RjRIV2RRTnVSVDFKT01oR01PRXJ6VDZOUnVUeVlyNVFqUlpPcFRvN0dRcVlw?= =?utf-8?B?em9qNWplbHZ5cGhiL0hydjA1eDFEYmhKclFvZU9VRXpNVnBCR0gvalIzRWFq?= =?utf-8?B?K0l4ajlBa1Q5N052by9qNFpLU3RCNk1WMGJQRmE3UW10aGtBMHVxc2hpS2V5?= =?utf-8?B?QS8vOGlzOVR6ejczQXByaE1wK3hUaFFKK1BPbnNmd3NDdjNTejFneHVvY3RK?= =?utf-8?B?RDQzb0k4NWRvUlFDM3dRWklDKytNQXpzb0FRMGRreFVSUkJQK3h4M1l5SjY0?= =?utf-8?B?K2srdDkxU2NncWZRSDN1YkhvM0JycWNoK1VDS1EzcnFNbmEvT1BUeUh0NlEr?= =?utf-8?B?MXBxb2xOQ3NmZlVaYW9TY0JJeGcvd3EzRVhzaUtTMktpKzFmUEJZRjluVUo5?= =?utf-8?B?eE8yOVkwLzVxd2FKWGFUdmNkNlVWVnhqT0lZNVRsMUlKUE84eUI5Y3JDamor?= =?utf-8?B?TzFQR1V5dm1HeERSQ3VSVVRoUEh1NGZzaHk5ODZQeGZJNG1tQlUrVVgvZzUw?= =?utf-8?B?TDhxWGZEQ1JXK0QwVm5WUERFYnJEWk1Ub2JGVmFHTmh6U1BzOXd3VENpQ0xI?= =?utf-8?B?WkNrVE4xeEs0NWlNZzJ1SkhzT09jRmYxdkNzaG8zazdKSnFzUUpFZTlGVWVH?= =?utf-8?B?MEdlMkpUbjJoOWQ1ZHJaM1ROdjNSVzB1djRlT0Q2WlV0QnJKblhzTkdBZFA4?= =?utf-8?B?OExtb2RqRERvWlAwMGpJdythU0l1c0ZQYXBrb3NpZGMvZEtablpYeWlaZGRQ?= =?utf-8?B?c1FTYVRFcVkycDE0bFQ2Sk9wWXNpay8zZHh2UGd1ZHpSQ0tDZTlyTVYzZGRO?= =?utf-8?B?SkpzQ3hNa29ib0N0c09XWHlJcTMzTHFRRHdUWEdSNTdqdzZpSHVrbTlybThV?= =?utf-8?B?MWVwKzEvVENudWpXS2xOcUtXeDY3VEMxRW1kcFJVVGk5WWc2cTBvMUZic1pa?= =?utf-8?B?akluOFJmM0VDcE9oNkxuRHdudjJwek5Ldk5STTJCWDlUTkJ3dW1MU2huMWdv?= =?utf-8?B?amJwQmdrajdKOERQN2VUS05BU2NoeXBHK1h0bzQyQ2tJTS9WSXA2d3Q3U3JE?= =?utf-8?B?aGFlT25qc05Td1B6YWVWZHliclovNk5CSTRGSFFDV3hlcWZPSTgwMnBvdUZT?= =?utf-8?B?YUltemE3aTZYblN3Q3h0Z1RndWFzK0xsdFQyRnlCTEtkcllnVk54NHdoR2lB?= =?utf-8?B?aGp3UmZZdnpjaWYyZ20zY1l3b3pRNWozalc5K2xnTnlaWUh4WmtLQWpGYXI5?= =?utf-8?B?cTVvZ0RrN2lUOFE3emc3Ylc4RFZ3akxuZkd3OTNWc3gzV2dVQlpUQkswLzdz?= =?utf-8?Q?nkgXupTDi0aprJm18wNzd9p//ddlvNYPGEgv0=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;6:Hbilpr02gmMu0YyhBpy+aVi4ACdtSA8ih34kwIvsmjJ6FuFBOXzzxD4kxJHevuDJRH+Y0ipsfN3E4N7INpldx6zZTvwjJbD4DA8wW2QBxo8iZ1yQQyWt/E26m9HAU370QIBThYgqZ/yb0kAhhu7yoiq3Zja1nch+XGjpWmf33GRQBsHdWevNp0G8TPb0QU4zCUelvy2Dj3CeHTunSvd+O7A82bP4aQc2w88xu4UgHXxPChFg28MpHRJzYtsqAFymbPPRNH31WS5BoVmpxIssA/9e3KU+bI8qONq7MdCyEqYvW8rqAr+ORS4gLG8ot+TXkiH2u53qIPzMe8v1IhrdDNG9uKRVttNB7E/hMT7LSIo=;5:8ytU+CiAB7LQv57pmbdTAfiD3t5tEiXs+oU7ZGwTPRzOr5flmxuenqKyVDhsHmqo+CsCZgQ+s+71sVo8PbQLeFHDl5wEK0/XNG+5qvExBQimSOl+Z/rPzniKMFzySUPhCx0yAzerRov0V8D7lQOjMwzQxk1IpaT1+40i9dUxiIE=;24:T+78D3/6bUtcZn5vHr6h7If//uE/zMYUf0jR/zDBEqS4LblmZrgkGpueWRnRWi1cPkzToVjeFSLMqK+OlKZyTgwSjTBw33/yuqqVQnidji0=;7:NzM9bjNVS/dgHKm+xO2EpYEzgn6/Ub/NvOp1JVziTh90v4nv0527H++zIYyI93antYrcuwJ+dMGSvVcZUQb6/zYmRpzGNscLv1NFlRnhgNSHdyKyYMQyh7rexnbCzgU7oR7ek3cJnslYNdQxEVDLLSuU1H4QX2uutlThMtvuUGucqU8wdx5SXEQC62lGByZR4+wOjox4Pc6tKbiOBqFEJeRQu6itRREiHHTbe/2kfmwDM3B1ag1+mx0jJ1qWtC0q SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;20:H53xfGz3+B1WQCcQlk0mU74HEEPZORnYNdGyK/UqIKHUcJn3M6wd+qCTsg+figfeKBJhttDfp/A0NjeZz0TYL7ZpjQqbA+MP72vAy11vQBzRK90Abwk8UjuHP2GyMwa5+t4MXktU+kqd9vndzJJrI4Z8Hkh1yWwQCJ72sv36o+1bO2WKuNoGNTq11xYGmidU6JDZfgd+1g9t//ClOI9QLgvIwAuqBz1J8+qDEQ8sbfc4ikqD+E/EweUfFMUEmc2j X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2017 20:01:09.7341 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6dfe873-81a5-4d73-78aa-08d522f5a13b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0157 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/3/17 2:42 PM, Borislav Petkov wrote: ... >> + if (psp_master->sev_state == SEV_STATE_UNINIT) { >> + ret = __sev_platform_init_locked(psp_master->sev_init, &argp->error); > Right, you're passing psp_master->sev_init (or whatever you're going to > end up calling it) down but then in __sev_platform_init_locked() you end > up doing > > if (!data) > data = &psp->cmd_buf; > > which looks silly. > > IOW, if not really required, __sev_platform_init_locked() could have > only one argument instead: > > static int __sev_platform_init_locked(int *error) The cmd_buf argument can be remove. I am have not looked at SEV-ES but it may be possible that during SEV-ES patches kvm driver may need to call the sev_platform_init() with different cmd_buf to initialize SEV-ES states. I can removed it in next version. -Brijesh