From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 685833876BD for ; Mon, 18 May 2026 17:57:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779127071; cv=none; b=ulgkJgRHbSaO77shOvnLG303VC1Y6MJvQ918sdQxeyjB90NsHfEDz7qnNN1Tqc/3iwz69SfBt5ij+9pWOf7pKWNRJ2xpTYpadlKV5VnTVfubaQMv1khIUq3M8Nagd+QDKkTqjT9wx1e9biaQA5Px48A72DEFfb8Fd2wzXsX/zTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779127071; c=relaxed/simple; bh=8Vp1BuTxGJcJD8AC4d+5NoDM0ihlVg+nG4ExSSlMHY4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YjgiMc8kHDRmJuKNITC1DjngvwHxSZNCtDqAT49u+6UwWw5VqgBGuvlgvXr+SSOtKTT+oiE6wEdMxw/CPET8/fUf7w7DeGVia0p9oa04iJ+iOXVJriDF8Gpny5PAV2gUMiRrfRNn6/gj186sB+Biv3cJZ2+kHGs0RN9/LYQDbUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Gto/qZ9v; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TxU8LZID; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Gto/qZ9v"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TxU8LZID" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IDbkA6353057 for ; Mon, 18 May 2026 17:57:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yc4/d8qtJswMAftQKu9HSCdPYUpDaigiy7xk3vlQtpg=; b=Gto/qZ9v871KoKiS 3kFXIT4ynbjQg/B30wEFJn+1nHNYBnPZcbo32cSDNRo1ljmQGs3VsiTE2dJiRxL+ 7K6er9M3QzqxWyIYspq0MuK76TUh1gqeiPtVCfk1szGI4bgGqTJ3tSE9dop+T9/I vUHCuuWSiaIUJIT7Tz9X6dQmCyMTMfSbyoNTMOYIlpML7Jgvv4tTg/IJ+eBvYy3t z2jyVCe7jLPQaASt7PkD3nS0S8wFa+sKr0rwHlHHUPXaCYcormQh7wcsh+tl+d8E RTiSSf5GuD9mGfL3i0dGGShSrEvg286fCaQAM71p8i5ccDS4fLJiiIgYQVDyPXfx QDtx3A== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e7xjajf7x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 17:57:49 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-514ae0e3ad6so51558471cf.0 for ; Mon, 18 May 2026 10:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779127069; x=1779731869; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yc4/d8qtJswMAftQKu9HSCdPYUpDaigiy7xk3vlQtpg=; b=TxU8LZIDVi7a8twLt1a97YK4TgC6AiKYgSpEHOa7Ks75gfSyYuWbJqX0fnWSZHZE8T iAxLIR1Us6bFslLFtMrb1tVCVuntVIAeBVk4voQGB+/EH5pTI2lVRoktRsLGNlx/ZqJz eT+Ic0xKI2oFmwio2JPJPA2AF9P9K+vExzunsRoxemsW8AGEDaXZvepCkQFnYATkvWyt TPsMObwFXqUT8jshzfFMp905/8/n9muat3qktU/pVZaTQriloM6sgYrkIJD1tHK8ECif rCDz+iuIHwnu5OtDndwCIU11Ka3Q6bZkh2jbDXdm2qfQcTLEydmoh6MYrM33e1f7djLB Pxgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779127069; x=1779731869; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yc4/d8qtJswMAftQKu9HSCdPYUpDaigiy7xk3vlQtpg=; b=ALbCcLqHkPFsnlrIpd6L8xPo4LMaJKJajWs+LEmiCEVloefRbmaHXKAVpm3h/FtgvC 2TJdcsx/mkUtWJtiIWd9Bp6HWGBun1voO4L/UN/Xv+y7y4xcRAV8E3V+jUBcVIZ/rA3b ZJ3RGjPLldDVaFCOIDq4v24XKGXb2ACH8rZvGLieG+/lOpaz1Av6dSSuqlJwMC3sewb2 St4Qr4H+As4PNjbFbUTnPPpyygqPAsM4tpp364P+moLvMeoBWZNuJ9BOEW63TOHxWGRF ACkbA5MznDmm7oTR88uUSLISk3x3uGlRFP+9BEmRtEISMLIsDPE7VfxCPBJWvGGjBcNa q8oQ== X-Forwarded-Encrypted: i=1; AFNElJ//YGEYIssFlJ5lWtgARy300fypGtRjEo0zO5HoknBAvpBbb9udkR6AzmFkAIF08qKjSHiqCgeE2jjIIc8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2Z3+cS+XNWjeJjPQvbMI1TvpzxTsYGRK+kkwSitSguxsWZRf6 hD/YjlewNtsy8jpmG3YDwIq1seG7ovF1r7/nPybo1kjxoNl2V4IeFs2ihWPQCVCXROUSav9lIdU QEvhl38zTWQndvt0FWd8kSHLxQ4bQEAh94mz80KpcAHqHGBAstUCd2g/weNuJLq0wg+U= X-Gm-Gg: Acq92OFi8bVi/Bslj3waAhO+wJFeZSd59GlnpzMrlyxYFUQ1EL4ZtJ0Vrs1xF4Hq7JX GCo0VhR28sYuA1HvWunas7nfkX5/djCTohLLrwZU9z7RVjVFA8emY+fCV3yoi9UYiKepDCnN5Lq aMfKVNVTyNxFS+MkiVJF2CwTSz5B9BvUvKaNKhrCsFmjYS9/sY4cWp92bUi/0iCP8y7XGtELTa6 mmR8ii2odnPW/XX78BAQ91ywNjLeHE3aoKtsHt/g9fl32nHWqvbjBL9KvEaA5ef+zGzb+GUzd8R tmOA/EQiaCSYZqNVlL3bw0zmQi5AkH3T9i1exxG3rX+VoOAdpjPAK52iftJPv9ltBjSQ4vVB/Ci bc5DiuKHLSSEVZ9usHjsHFRxsOH65Zt1bOrvsic+omRgoGemOTTXJmzPdXaDhxfeTLPyizu9YV0 DRaD9PXAk6 X-Received: by 2002:a05:622a:1386:b0:50f:b7b3:2ebb with SMTP id d75a77b69052e-51641928873mr254152611cf.33.1779127068691; Mon, 18 May 2026 10:57:48 -0700 (PDT) X-Received: by 2002:a05:622a:1386:b0:50f:b7b3:2ebb with SMTP id d75a77b69052e-51641928873mr254152061cf.33.1779127068071; Mon, 18 May 2026 10:57:48 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:e390:12f5:ed3c:ffd9? ([2a05:6e02:1041:c10:e390:12f5:ed3c:ffd9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4dac000sm276575975e9.0.2026.05.18.10.57.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 10:57:47 -0700 (PDT) Message-ID: <9ae2a769-4b2a-4990-90d4-0a1c0f05ba82@oss.qualcomm.com> Date: Mon, 18 May 2026 19:57:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] thermal: armada: replace msleep with usleep_range for short durations To: Mayur Kumar , miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511153750.183640-1-kmayur809@gmail.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260511153750.183640-1-kmayur809@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDE3NyBTYWx0ZWRfXzUMqSj/1EGlm 4kPgdM1tLR0u6FvgZ+kvCEcbZoHGhnoBf422onD1lnwu6Y0TF5uSoBtMp+Jqgi8AlLUOpc+dhlz mVNnNRGQ5FYmhccI/mFzDS9Zh0FIkR2IbUTLizmVFbiZ8dpbd9fHiWF6WxNQehTta/Z+nW/r6Ca 6UOEUbNOBGcycRPqtNx2UXpTTpA6AyVMX/+Mubl6Sb1YNQVfZ18DD/rNJV7KpxPo6pImJenxwjP XX/dA7C9+AIEM6Aoo8JQtZP3ESCDhhjnGCiT7usMFqRY2HgujfPyFBIsyZyi/en987W59k73Pog TkyhgIRF53T4zZuay/JTChzu3iItaOpSSFbAELxYrHJGfwZRMcUbBOTQbZExzUFLJohzQSM3bQ+ RMTP33RF2NJtxF/QMbs3ZSyd3vy13XD6qL6YkwDHIcbrzXI7SpRJ8ZUqnsVfkHXs4gx3HtFOW5F nLOuwoCY4FkrgvYolBA== X-Authority-Analysis: v=2.4 cv=BYHoFLt2 c=1 sm=1 tr=0 ts=6a0b531d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=pGLkceISAAAA:8 a=CvSXXL9ViinJZdB_jLEA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 8ZjppQAhYAApzEG7v-NnL1pwSBTJKwFU X-Proofpoint-GUID: 8ZjppQAhYAApzEG7v-NnL1pwSBTJKwFU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180177 On 5/11/26 17:37, Mayur Kumar wrote: > The checkpatch tool warns that msleep(10) can sleep for up to 20ms. > According to Documentation/timers/timers-howto.rst, usleep_range() > should be used for delays between 1ms and 20ms to provide better > timing accuracy. > > Replace the 10ms msleep with a 10ms-11ms usleep_range. > > Signed-off-by: Mayur Kumar > --- Miquel, if you are not against this change, I'll pick it up Thanks > drivers/thermal/armada_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c > index c2fbdb534f6..96965f393b4 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -178,7 +178,7 @@ static void armada370_init(struct platform_device *pdev, > > regmap_write(priv->syscon, data->syscon_control1_off, reg); > > - msleep(10); > + usleep_range(10000, 11000); > } > > static void armada375_init(struct platform_device *pdev,