From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBD7C38159 for ; Fri, 20 Jan 2023 05:24:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbjATFYl (ORCPT ); Fri, 20 Jan 2023 00:24:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230341AbjATFY0 (ORCPT ); Fri, 20 Jan 2023 00:24:26 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82234EF8C; Thu, 19 Jan 2023 21:15:01 -0800 (PST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30K3mYPb017468; Fri, 20 Jan 2023 04:47:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=T4sS9BoBfz9WEu5JOgwas1AqI7OGUq6xBiqPC0K1GBU=; b=kuKViTnX3eCfB9njWvcViKsgUYOpNQxMZkfBEB6DWAVAQts6u6KPlKsNn7f2IcBTUhpU jXMfgker/gRhcA/Ly/3m+u3KOqAxJK2YPRO97xM8B05VQblS32+xqLG02V5QE2z1qyMW qYLqaB5AvKdxEryHpUqfgdrsY0iPoOCXv6K+bZ0+f4JBTHec3cgPNc9b/UmcyzAUW1XS 0F9LVxOvUFs5IRfCJxUX5ElHm+kwqkswEfnClIUhbc9vC3JcJ0uF5HIsnGCOe8XXYz2p P/CbjpVkQS1wS2jPS5E2KoWo7Ltx3HMMBE4gOsxdQ/QjkRhOH7FDT3KBAnKlm4WyuN5d /A== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n75w3hs82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Jan 2023 04:47:18 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30K4lH5A001066 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Jan 2023 04:47:17 GMT Received: from [10.216.43.228] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 19 Jan 2023 20:47:11 -0800 Message-ID: <9ae3b1b0-e9d6-6370-667b-88af5d0efa2e@quicinc.com> Date: Fri, 20 Jan 2023 10:17:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 4/7] arm64: dts: qcom: sc7280: Update VA/RX/TX macro clock nodes Content-Language: en-US To: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , References: <1674131227-26456-1-git-send-email-quic_srivasam@quicinc.com> <1674131227-26456-5-git-send-email-quic_srivasam@quicinc.com> <17b895c0-3985-a012-9b02-94d5ebb11ff9@linaro.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm In-Reply-To: <17b895c0-3985-a012-9b02-94d5ebb11ff9@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: BnwV-s8f1FOGMETikuYZKLkrVEE2vGAn X-Proofpoint-GUID: BnwV-s8f1FOGMETikuYZKLkrVEE2vGAn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-20_02,2023-01-19_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 mlxscore=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301200042 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/19/2023 7:01 PM, Krzysztof Kozlowski wrote: Thanks for your time Krzysztof!!! > On 19/01/2023 13:27, Srinivasa Rao Mandadapu wrote: >> Update VA, RX and TX macro and lpass_tlmm clock properties and >> enable them. > Everything is an update and this does not explain what exactly you are > updating in the nodes and why. > >> Signed-off-by: Srinivasa Rao Mandadapu >> Tested-by: Mohammad Rafi Shaik >> --- >> .../qcom/sc7280-herobrine-audioreach-wcd9385.dtsi | 59 ++++++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi >> index 81e0f3a..674b01a 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi >> @@ -8,8 +8,67 @@ >> >> #include >> >> +/delete-node/ &lpass_rx_macro; > Why? Actually in SoC dtsi (sc7280.dtsi) power domains property used. Which is not required for ADSP based solution. As there is no way to delete individual property, deleting node and recreating it here. > >> +/delete-node/ &lpass_tx_macro; >> +/delete-node/ &lpass_va_macro; >> + >> /{ >> /* BOARD-SPECIFIC TOP LEVEL NODES */ >> + lpass_rx_macro: codec@3200000 { >> + compatible = "qcom,sc7280-lpass-rx-macro"; >> + reg = <0 0x03200000 0 0x1000>; > Why? They are the same. Explained above. > >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&lpass_rx_swr_clk>, <&lpass_rx_swr_data>; > Still the same... > >> + >> + clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&lpass_va_macro>; >> + >> + clock-names = "mclk", "npl", "macro", "dcodec", "fsgen"; > This is different... > >> + >> + #clock-cells = <0>; >> + #sound-dai-cells = <1>; > But this not. > > > Best regards, > Krzysztof >