From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C409CE7A88 for ; Sat, 23 Sep 2023 08:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230525AbjIWI16 (ORCPT ); Sat, 23 Sep 2023 04:27:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230490AbjIWI1z (ORCPT ); Sat, 23 Sep 2023 04:27:55 -0400 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C550199 for ; Sat, 23 Sep 2023 01:27:49 -0700 (PDT) Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTP id jq43qI3YHbK1VjxzQqkGyn; Sat, 23 Sep 2023 08:27:49 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id jxzQqdnE6uHtrjxzQqVMbh; Sat, 23 Sep 2023 08:27:48 +0000 X-Authority-Analysis: v=2.4 cv=B8eqbchM c=1 sm=1 tr=0 ts=650ea184 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=P-IC7800AAAA:8 a=IpJZQVW2AAAA:8 a=7YfXLusrAAAA:8 a=QX4gbG5DAAAA:8 a=JfrnYn6hAAAA:8 a=cm27Pg_UAAAA:8 a=VwQbUJbxAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=d3PnA9EDa4IxuAV0gXij:22 a=IawgGOuG5U0WyFbmm1f5:22 a=SLz71HocmBbuEhFRYD3r:22 a=AbAUZ8qAyYyZVLSsDulk:22 a=1CNFftbPRP8L7MoqJWF3:22 a=xmb-EsYY8bH0VWELuYED:22 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3BINsmqXz1Xyl2+8Q/ewcOfCUe3yZ9S3ok1tGaIGWpQ=; b=dfRIeyp17Ir2q5YzY/Lu2aJVlr yZ90fP3exjLnH7hpn4aXidpYSZy7TEreWDUzBr+zE/u7hm10l8tH2v09Jy3KbgfTdjvAh8bHqm73f QrF74948pSNHfGzh/GwWAW2obItxIHLqaD5im6CD9RoHY/dPWtLULF2EY+RKpyaazNpfujqqvkNF6 ZZA8SapT+68yoQpT/PY4yFVqottgii1rPWhDEMe/C6BA928gDmySrxiVaSI9QMyaOB3Zpq2P99SuT iiCaxNoBAJ/Sdp/xv56x9RWUsSazrXRR+e7oalrawFvefXibTjvZ6FYLRW6IR+9FNH3NYFP7oEDiv xUr7tVZg==; Received: from [94.239.20.48] (port=40090 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qjxzP-003XHR-0X; Sat, 23 Sep 2023 03:27:47 -0500 Message-ID: <9ae58a8a-04c1-90ac-cf50-7366bff42084@embeddedor.com> Date: Sat, 23 Sep 2023 10:28:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: Annotate struct hci_rings_data with __counted_by Content-Language: en-US To: Kees Cook , Alexandre Belloni Cc: Nicolas Pitre , Len Baker , Boris Brezillon , linux-i3c@lists.infradead.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230922175019.work.129-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230922175019.work.129-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qjxzP-003XHR-0X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:40090 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 68 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEjVPXa8h5cCEBSmUvLlDXBWQ0GhaMA1UGFRuzvurrrsG+uFJ13Vd+EDy//lYXwFIdDJjeBIL38zjZy8HIt3ByMJ5c7+bU/TF7f0PXBCBVHdAoTT+ije c297d1pHEKmsuio2ZJwsXH2xRItK6eENd9yxSMHOCzJ3JEqb9QDJPsR3npDQIspBY31OTfaDYTa+jrNAkdWGvk55LRpvjiv0nL91k7YXExoNLJS1HgxDJIl2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/22/23 11:50, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct hci_rings_data. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Alexandre Belloni > Cc: Nicolas Pitre > Cc: Len Baker > Cc: Boris Brezillon > Cc: linux-i3c@lists.infradead.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/i3c/master/mipi-i3c-hci/dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c > index 2990ac9eaade..a1ecdfc35641 100644 > --- a/drivers/i3c/master/mipi-i3c-hci/dma.c > +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c > @@ -139,7 +139,7 @@ struct hci_rh_data { > > struct hci_rings_data { > unsigned int total; > - struct hci_rh_data headers[]; > + struct hci_rh_data headers[] __counted_by(total); > }; > > struct hci_dma_dev_ibi_data {