From: Andrew Lunn <andrew@lunn.ch>
To: Alistair Francis <alistair23@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux@armlinux.org.uk, hkallweit1@gmail.com,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH] include: mdio: Guard inline function with CONFIG_MDIO
Date: Mon, 4 Nov 2024 14:49:50 +0100 [thread overview]
Message-ID: <9ae6af15-790a-4d34-901d-55fca0be9fd2@lunn.ch> (raw)
In-Reply-To: <20241104070950.502719-1-alistair.francis@wdc.com>
On Mon, Nov 04, 2024 at 05:09:50PM +1000, Alistair Francis wrote:
> The static inline functions mdio45_ethtool_gset() and
> mdio45_ethtool_ksettings_get() call mdio45_ethtool_gset_npage() and
> mdio45_ethtool_ksettings_get_npage() which are both guarded by
> CONFIG_MDIO. So let's only expose mdio45_ethtool_gset() and
> mdio45_ethtool_ksettings_get() if CONFIG_MDIO is defined.
Why? Are you fixing a linker error? A compiler error?
In general, we don't want #ifdef if they are not necessary, because
they reduce the effectiveness of build testing.
Andrew
next prev parent reply other threads:[~2024-11-04 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 7:09 Alistair Francis
2024-11-04 13:42 ` kernel test robot
2024-11-04 13:49 ` Andrew Lunn [this message]
2024-11-05 0:21 ` Alistair Francis
2024-11-05 0:37 ` Andrew Lunn
2024-11-05 1:21 ` Alistair Francis
2024-11-05 3:02 ` Andrew Lunn
2024-11-04 13:53 ` kernel test robot
2024-11-04 22:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae6af15-790a-4d34-901d-55fca0be9fd2@lunn.ch \
--to=andrew@lunn.ch \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®