From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E23CC433EF for ; Fri, 18 Mar 2022 09:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234739AbiCRJ4s (ORCPT ); Fri, 18 Mar 2022 05:56:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230505AbiCRJ4p (ORCPT ); Fri, 18 Mar 2022 05:56:45 -0400 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B626178686 for ; Fri, 18 Mar 2022 02:55:25 -0700 (PDT) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4KKfWv0q49z9sT4; Fri, 18 Mar 2022 10:55:23 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ypqx9pvwL4Ck; Fri, 18 Mar 2022 10:55:23 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4KKfWt6h7pz9sT2; Fri, 18 Mar 2022 10:55:22 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D35208B78D; Fri, 18 Mar 2022 10:55:22 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id iOqzYB9RuqTt; Fri, 18 Mar 2022 10:55:22 +0100 (CET) Received: from [192.168.202.177] (unknown [192.168.202.177]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2E47E8B767; Fri, 18 Mar 2022 10:55:22 +0100 (CET) Message-ID: <9aebcbbf-aaba-f7e8-7397-18284e74ab0d@csgroup.eu> Date: Fri, 18 Mar 2022 10:55:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions Content-Language: fr-FR From: Christophe Leroy To: Lyude Paul , Ben Skeggs , Karol Herbst , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <2d97ae92b9c06214be0e088a72cf303eb591bf01.1646414295.git.christophe.leroy@csgroup.eu> <47e09d6010852db928c0de29b89450ea7eee74d8.camel@redhat.com> <672043db-5290-293c-fde4-440989c78d09@csgroup.eu> In-Reply-To: <672043db-5290-293c-fde4-440989c78d09@csgroup.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, Le 05/03/2022 à 10:51, Christophe Leroy a écrit : > > > Le 05/03/2022 à 08:38, Christophe Leroy a écrit : >> >> >> Le 04/03/2022 à 21:24, Lyude Paul a écrit : >>> This mostly looks good to me. Just one question (and one comment down >>> below >>> that needs addressing). Is this with ppc32? (I ask because ppc64le >>> doesn't >>> seem to hit this compilation error). >> >> That's with PPC64, see >> http://kisskb.ellerman.id.au/kisskb/branch/chleroy/head/252ba609bea83234d2e35841c19ae84c67b43ec7/ >> >> >> But that's not (yet) with the mainline tree. That's work I'm doing to >> cleanup our asm/asm-protoypes.h header. >> >> Since commit 4efca4ed05cb ("kbuild: modversions for EXPORT_SYMBOL() >> for asm") that file is dedicated to prototypes of functions defined in >> assembly. Therefore I'm trying to dispatch C functions prototypes in >> other headers. I wanted to move prom_init() prototype into asm/prom.h >> and then I hit the problem. >> >> In the beginning I was thinking about just changing the name of the >> function in powerpc, but as I see that M68K, MIPS and SPARC also have >> a prom_init() function, I thought it would be better to change the >> name in shadowrom.c to avoid any future conflict like the one I got >> while reworking the headers. >> >> >>>> @@ -57,8 +57,8 @@ prom_init(struct nvkm_bios *bios, const char *name) >>>>   const struct nvbios_source >>>>   nvbios_rom = { >>>>          .name = "PROM", >>>> -       .init = prom_init, >>>> -       .fini = prom_fini, >>>> -       .read = prom_read, >>>> +       .init = nvbios_rom_init, >>>> +       .fini = nvbios_rom_fini, >>>> +       .read = nvbios_rom_read, >>> >>> Seeing as the source name is prom, I think using the naming convention >>> nvbios_prom_* would be better then nvbios_rom_*. >>> >> >> Yes I wasn't sure about the best naming as the file name is >> shadowrom.c and not shadowprom.c. >> >> I will send v2 using nvbios_prom_* as a name. > > While preparing v2 I remembered that in fact, I called the functions > nvbios_rom_* because the name of the nvbios_source struct is nvbios_rom, > so for me it made sense to use the name of the struct as a prefix for > the functions. > > So I'm OK to change it to nvbios_prom_* but it looks less logical to me. > > Please confirm you still prefer nvbios_prom as prefix to the function > names. > Are you still expecting a v2 for this patch ? As the name of the structure is nvbios_rom, do you really prefer the functions to be called nvbios_prom_* as you mentionned in your comment ? In that case, do you also expect the structure name to be changed to nvbios_prom ? Thanks Christophe