From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B0EC433E0 for ; Wed, 27 Jan 2021 10:16:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F99E2072C for ; Wed, 27 Jan 2021 10:16:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234208AbhA0KPg (ORCPT ); Wed, 27 Jan 2021 05:15:36 -0500 Received: from foss.arm.com ([217.140.110.172]:36810 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235688AbhA0KMv (ORCPT ); Wed, 27 Jan 2021 05:12:51 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8657A31B; Wed, 27 Jan 2021 02:11:56 -0800 (PST) Received: from [10.57.4.29] (unknown [10.57.4.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EA1D23F66B; Wed, 27 Jan 2021 02:11:52 -0800 (PST) Subject: Re: [RFC][PATCH 0/3] New thermal interface allowing IPA to get max power To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, vireshk@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, Dietmar.Eggemann@arm.com, amitk@kernel.org, rui.zhang@intel.com, cw00.choi@samsung.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com References: <20210126104001.20361-1-lukasz.luba@arm.com> <20210127091540.xesvwoeavyaf37jn@vireshk-i7> From: Lukasz Luba Message-ID: <9aecd2cd-771e-58b8-6672-f133600b70b5@arm.com> Date: Wed, 27 Jan 2021 10:11:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210127091540.xesvwoeavyaf37jn@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/27/21 9:15 AM, Viresh Kumar wrote: > On 26-01-21, 10:39, Lukasz Luba wrote: >> As it's a RFC, it still misses the cpufreq sysfs implementation, but would >> be addressed if all agree. > > Not commenting on the whole stuff but if you ever need something for cpufreq, it > is already there. Look for these. > > store_one(scaling_min_freq, min); > store_one(scaling_max_freq, max); > > Hopefully they will work just fine. > So, can I assume you don't mind to plumb it into these two? Yes, I know them and the tricky macro. I just wanted to avoid one patch for this macro and one patch for cpufreq_cooling.c, which would use it. If you agree and Chanwoo agrees for the devfreq, and Daniel for the new callback in cooling device, then I would continue by adding missing patches for cpufreq-cooling part. Regards, Lukasz