From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 262D2313E31 for ; Fri, 5 Dec 2025 09:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764927802; cv=none; b=TiO0fPMMwKN3IjovVx0t5zD1ZpOrFckPSdrfEz12kZFjQ7hqsGS+hmROCWQPPE5b0q7QeqnpQABvYzOg4IkPRvsQtmVUlPCbuxiJdt93DV+qQbMNbS8u7nQxFCBPxCnqySCbCYj2w41PAmS6VDNKFUHdX1YaNWpZsd7tOfJCMYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764927802; c=relaxed/simple; bh=1Dtjn/s+S6Phy//fdwQyXqaw9wMZ7QcYaRMSJ3fhAbQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SGbapGK1ke04iCRvKxEu5+UM2YsFreohXk40PnW1Dynn1GLBUQ/4EhxGpUBtInxJGW35idgkKpZQpic5dpoEN5Z/sxIOfodBMSQXY4uhEevedX0eSt9iEMHaTDHxvDJn7k876D7yLWpcFPi78vIQT/0iOptrwKy4HQyW2e5QiOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hiv7ifi9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iQ3qSePG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hiv7ifi9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iQ3qSePG" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B54K2JH3643843 for ; Fri, 5 Dec 2025 09:43:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 051Y9IVu26emFyHODILoIGxYykNYI0ydzB1GW1bIHzg=; b=Hiv7ifi9lGDpNtur gq2NlUeAinhoE8WqF2rdgDRthwpdZzK9Rq/sVH5+dhhVrbvNL7ZunBqYxxH+f+pU 97mRCgoM1EmuMa2Bcc+RBd1D5rD5+AnJGjIN44Gw0fhTd6hh5aLx0bVKm6M7O8Bq YqyNPLP4hBlrsNIP0aZ1WT3ZvRzH+qoRWGb8ZW8ay4yWzpiVamW0KbeJpUufnBVV 2tKr3NcNopQcrOcfqLsNLlCQhs0DV0mTUmI7e3Ni2XuCw+aThxmcYu01jhlHKK70 Dnjr3fkK0dk5d+IOOOmSxtIBTdFLsgE+xlA8DhaMZpuklslsxbfU0CWghYRxE6X4 ZVM1NQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aur9artw1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Dec 2025 09:43:14 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-882384d1cc2so6212046d6.3 for ; Fri, 05 Dec 2025 01:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764927794; x=1765532594; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=051Y9IVu26emFyHODILoIGxYykNYI0ydzB1GW1bIHzg=; b=iQ3qSePGJPXM1OpDctVmQSn8ovN05AY8dSyrluKwBmqQ2pJmRuyZ+zVCqjKtc36pWy ocGVdZbyYvigvLQ6M0fSK6t4cPR+36U1gX2jtw4LWB+vT5uc3j7z0iQX7ChJu9WRjX47 Tj5Bgn8TWVfLzJOcxnpCAVtEMjswv7aVytNT89Pr5XTse/4FPFMC+fUXP+3w/s5YlHOl eM3jFlu8idyHv5N3lERXeYIrJNm5PwfCa/+/ARV9GuORW4fnn3UahDfrvXw/YPMQy0L9 7TtEHHJ5/ixPYfE/Q7C485Z4GlIstdvYA0EFFswDujB0RBGC22Kl2oiStNunnKKn6JL9 fjJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764927794; x=1765532594; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=051Y9IVu26emFyHODILoIGxYykNYI0ydzB1GW1bIHzg=; b=u6qtx3+QwwrUMSX36PaMGDcwbsAuTYTmgBDd9/3EeUMA2wWmrrWEQp5GbrYpGIYEtU 5r3XxO82/LWkjZiOuHcjrnrvymKN9LkVoX8LqeElctkNf2QyO+1R5GYqPIXYigTlCTP7 RWSGvoRz5XQ451rUuqnx9SpS48s9WXzfOeE4adLGwEipG+dl1VJkeT/GPAHQjgn2/h+9 6z8Y9anorfJmrUm56xASkeiv2ITabNtFFVVksbam8DlQDtYyBS4+pY+/Eaw+AbTjTdvu qekr2Z80Y57e2X1vM4koCObVU2oHDk0T6wdxvaYEuWMWX9VoYSS6Xv6+qz+XhOhmwAoF O/Dw== X-Forwarded-Encrypted: i=1; AJvYcCV1NdpBbQ3coGLZrHTFVpsbX+qi3UcBhBZQow7C8cf/z4ZpKnpHPHkPbcUOofkOolrYgImbmtclcBA7hag=@vger.kernel.org X-Gm-Message-State: AOJu0YzZAbwSZBCEGKCiNOC9kE7xpHNVHtvhxxAACoZzgYdo+uc9cWwl sQWoHiGYkU1jg5xUkflFDFLCrKQxHAnM3P2IrYdFDgSZe9kFAqCdeDuUDY03FaefkxYKcdfMSGW N1jjJNA5Oe3xqtusYYn0NEhbz1t0yt/3EJ8IA7f2MWa8lbI8dLxy6HWsMbJmddqirRwI= X-Gm-Gg: ASbGncs4ei7JKSWMKD31FAgsJek+YQZUpczad86ISmOgXY0DILFhxydUWtKpWIsF2o6 WRqsp/0vTYf2+pqaoql1Gz1/pAUDc6quB61UmarwgErBkXBhinYgoCXr1bL/cACD12cb9DcSwlo nYp8/5LdyivHuwnf3TXgLlw0631RmYfDH2ACRdRW9lK035vLekOngLTElszQe6louMZpiDyxXKD Se2tgMXHDy/x3Qe+6t6AjxYGlJzk9B6t0sfdeAQ6vmfsFQlFbuEFOBvzA3RkaLi3lp/ltf5a7SL RPg9IBREOSnzB3zl64ANVM7GuOO2ziTaMt21ZqC8x0Aawx7uEcEzhLIWe+r2uvtOH3M57Iuy0Bx vye1jekA/pw12hXJHR0UTq5Zg2DbjGbnBKK+l2T4eFtbL1ydCXoSvU9zBeK5+75L+pg== X-Received: by 2002:a05:6214:401:b0:880:4954:6af5 with SMTP id 6a1803df08f44-8881d8519aamr104391166d6.7.1764927793870; Fri, 05 Dec 2025 01:43:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IE00PIHFiV3/tKHkvG/O7NMn8xXqMnCgGo5KoqDYRTk+K+AnVBCSbZOXWXZ68Sp48OzMKygug== X-Received: by 2002:a05:6214:401:b0:880:4954:6af5 with SMTP id 6a1803df08f44-8881d8519aamr104390936d6.7.1764927793472; Fri, 05 Dec 2025 01:43:13 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-597d7b1a7c5sm1350921e87.11.2025.12.05.01.43.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Dec 2025 01:43:12 -0800 (PST) Message-ID: <9af39b45-581b-4e25-8ab9-19015f00d6bc@oss.qualcomm.com> Date: Fri, 5 Dec 2025 10:43:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH WIP v2 3/8] media: qcom: camss: Prepare CSID for C-PHY support To: david@ixit.cz, Robert Foss , Todor Tomov , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , Casey Connolly , "Dr. Git" Cc: Joel Selvaraj , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251204-qcom-cphy-v2-0-6b35ef8b071e@ixit.cz> <20251204-qcom-cphy-v2-3-6b35ef8b071e@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251204-qcom-cphy-v2-3-6b35ef8b071e@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Veb6/Vp9 c=1 sm=1 tr=0 ts=6932a932 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=QkNP4qxLxUHCfFU9Qr0A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: Mv4AzI-NyqkcotmhjNH2qb6gH8Tm1nP1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA3MCBTYWx0ZWRfX9B43VGPjzxws UZJqzcPFMJvSEy9aQNX6NGtmojONu4MaMdoLUgykYcuOf7iCbJiskVpKYh6Xz1D78nfUS0HZfi+ x8zeMmfoQIVEhPaSth2SAWACbPdDSxWyulFKn600Wx4jgj2PMy/OZeRYW4fir+LMq1KW7MNzl22 LN0a0e1VHB+M/yR9IgTxodWuuHHohuvtFCsU8TMY45d7S7uRa5qnMQiMHxMNTbk9rNlrD8WuUVY WPFWaeTJ+xhFqsP49I3PNANXbgPd1aWGaTYWmGaUblL9P1Mxpz8T88JyBvR0qSR0Iy5HFKqMobw K4tICyNJpVIZ8G7iAZ9M9+K766pK7Gh1WzB3TqVJQT4W4aBr0GsrTC+9JtzJevCBub4NJE6Dn9t VOYBofb5tmWMNjtgto+Smy5SDkWqKw== X-Proofpoint-ORIG-GUID: Mv4AzI-NyqkcotmhjNH2qb6gH8Tm1nP1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_03,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050070 On 12/4/25 5:32 PM, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Inherit C-PHY information from CSIPHY, so we can configure CSID > properly. > > CSI2_RX_CFG0_PHY_TYPE_SEL must be set to 1, when C-PHY mode is used. > > Signed-off-by: David Heidelberg > --- > drivers/media/platform/qcom/camss/camss-csid-gen2.c | 1 + > drivers/media/platform/qcom/camss/camss-csid.c | 1 + > drivers/media/platform/qcom/camss/camss-csid.h | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.c > index 2a1746dcc1c5b..033036ae28a4f 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-gen2.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-gen2.c > @@ -183,6 +183,7 @@ static void __csid_configure_rx(struct csid_device *csid, > val = (lane_cnt - 1) << CSI2_RX_CFG0_NUM_ACTIVE_LANES; > val |= phy->lane_assign << CSI2_RX_CFG0_DL0_INPUT_SEL; > val |= phy->csiphy_id << CSI2_RX_CFG0_PHY_NUM_SEL; > + val |= csid->phy.cphy << CSI2_RX_CFG0_PHY_TYPE_SEL; This field is 1-wide, this would be neater: if (csid->phy.cphy) val |= BIT(CSI2_RX_CFG0_PHY_TYPE_SEL); Konrad