From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059AbdDCRKg (ORCPT ); Mon, 3 Apr 2017 13:10:36 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:22120 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751957AbdDCRKf (ORCPT ); Mon, 3 Apr 2017 13:10:35 -0400 Subject: Re: [PATCH 0/5] iommu/omap: Add support for iommu-groups and 'struct iommu_device' To: Joerg Roedel , References: <1490962248-12602-1-git-send-email-joro@8bytes.org> CC: From: Suman Anna Message-ID: <9af51f75-312a-8137-82d1-e3b08cec3448@ti.com> Date: Mon, 3 Apr 2017 12:09:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1490962248-12602-1-git-send-email-joro@8bytes.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg, On 03/31/2017 07:10 AM, Joerg Roedel wrote: > Hi, > > here is a small patch-set for the omap-iommu driver to make > it use new features of the iommu-core. Please review. Thanks for the patches - this has been on my TODO list but you beat me in getting there first :). Are these for 4.12? I have given the series a quick try and these currently break the functionality. I am investigating the failures, so will mostly need some additional changes. Let me know if you want me to take up posting of the v2. Meanwhile, I have added some comments on the patches. regards Suman > > Thanks, > > Joerg > > Joerg Roedel (5): > iommu/omap: Move data structures to omap-iommu.h > iommu/omap: Permanently keep iommu_dev pointer in arch_data > iommu/omap: Set dev->archdata.iommu = NULL in omap_iommu_remove_device > iommu/omap: Make use of 'struct iommu_device' > iommu/omap: Add iommu-group support > > drivers/iommu/omap-iommu.c | 137 ++++++++++++++++++++----------- > drivers/iommu/omap-iommu.h | 35 ++++++++ > include/linux/platform_data/iommu-omap.h | 15 ---- > 3 files changed, 124 insertions(+), 63 deletions(-) >