From: James Clark <james.clark@linaro.org>
To: Lukas Bulwahn <lbulwahn@redhat.com>,
Mark Brown <broonie@kernel.org>,
Ciprian Marian Costea <ciprianmarian.costea@nxp.com>,
Larisa Grigore <Larisa.Grigore@nxp.com>,
Stoica Cosmin-Stefan <cosmin.stoica@nxp.com>,
linux-spi@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH] spi: spi-fsl-dspi: Revert unintended dependency change in config SPI_FSL_DSPI
Date: Mon, 16 Jun 2025 10:34:15 +0100 [thread overview]
Message-ID: <9af5522e-02e3-4a82-a9df-20c71ebb3875@linaro.org> (raw)
In-Reply-To: <20250616091955.20547-1-lukas.bulwahn@redhat.com>
On 16/06/2025 10:19 am, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
> Commit 9a30e332c36c ("spi: spi-fsl-dspi: Enable support for S32G
> platforms") reworks the dependencies of config SPI_FSL_DSPI, but introduces
> a typo changing the dependency to M5441x to a dependency on a non-existing
> config M54541x.
>
> Revert the unintended change to depend on the config M5441x.
>
> Fixes: 9a30e332c36c ("spi: spi-fsl-dspi: Enable support for S32G platforms")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
> drivers/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 60eb65c927b1..f2d2295a5501 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -647,7 +647,7 @@ config SPI_FSL_SPI
> config SPI_FSL_DSPI
> tristate "Freescale DSPI controller"
> select REGMAP_MMIO
> - depends on ARCH_MXC || ARCH_NXP || M54541x || COMPILE_TEST
> + depends on ARCH_MXC || ARCH_NXP || M5441x || COMPILE_TEST
> help
> This enables support for the Freescale DSPI controller in master
> mode. S32, VF610, LS1021A and ColdFire platforms uses the controller.
How did that get there... Sorry for the breakage
Reviewed-by: James Clark <james.clark@linaro.org>
next prev parent reply other threads:[~2025-06-16 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 9:19 Lukas Bulwahn
2025-06-16 9:34 ` James Clark [this message]
2025-06-16 16:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9af5522e-02e3-4a82-a9df-20c71ebb3875@linaro.org \
--to=james.clark@linaro.org \
--cc=Larisa.Grigore@nxp.com \
--cc=broonie@kernel.org \
--cc=ciprianmarian.costea@nxp.com \
--cc=cosmin.stoica@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lbulwahn@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas.bulwahn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®