From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B7B4D0CE9 for ; Fri, 9 Oct 2026 11:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791545802; cv=none; b=aistPMeGpXBz4a8JGIqw6URKa8jtcXTQbrP11YWBMVnDs7AHLAAPZyqI9b1qZyatgMc+qD1YixeLTt3hghZ28k7WGTT6DZbo4Ath49TdsA+GZ7VzGF6inDtI8C4jtJ6Jl5AZvQivfHTzDuBQj6LeZG616jQRdHF6tiLG5vpVSeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791545802; c=relaxed/simple; bh=fSqnBG2yF18kOADnxH5nz6P+JiP6lhW/3+Fxloi+FYc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E+LFwYTuFVzy85O/2hYgtxMqDDT1a+8dwTIcodNRRL8IwLLSkc4KUeEIiMU11tH7zKORXKE3Wk7Y2n95SNZQo+66mLjMleJui/SYXzEIBiCj4s6hbJjQwdFZdsTdYWRDEQKT8k1Jr7uBtwPsefZdwjTWXCAjkTDVN9kK9HtIAr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AmYvUBv/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hl3qZguR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AmYvUBv/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hl3qZguR" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 699A4hFR1336320 for ; Fri, 9 Oct 2026 11:36:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LpoT01wAxSeGbAtr3r8DJqlxKzqo+vdrIEEQQ4fC6DE=; b=AmYvUBv/bs1sH++b a1yhg9FJDgQSLnbzQlc2Z7xH3CvA9h4hhopqh499NgtquM2X/2PeGRgEjkC/NV0p /rjmK88qTn6CifCrjWYlcRfdcGdcc/o9qqfXptPJB8A7yfhWMMpUoK0gRh4DYsXd o5n6BuE2p//kpV5D6HIk1FNmPdeD+3HNAg/jwGg89DENRJuMYMEhWNTOeoSxpzE3 XGbb0qRz+USxTb0SEhf42fQ3ExDlAiE6+JpBWNj8+lgemwhHCT3iO+xVPl6iJMmh u5fl2+IoDRMzDogiNMo8EJxMMbJJ/ZBG9bLhu/N8OkFiMAdRpqPs5vcOGB0h2bVN 0M7BmA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h6x6wg9h2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Oct 2026 11:36:32 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38ecc48b3c2so11057353a91.1 for ; Fri, 09 Oct 2026 04:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791545791; x=1792150591; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LpoT01wAxSeGbAtr3r8DJqlxKzqo+vdrIEEQQ4fC6DE=; b=Hl3qZguRBi235XjF8AOLWaUMe/+brHbULdrRLgUwd8ZfIA5taCQUSXlUHIchShjWmn gEoDYE3cwbqRDI3w//8zXJvgzyosxFgfTmPeieVfv6bGmJ/eh74h76n9viu8GDMFjsgW OB6Ns8X99lzzxEf1vBgSWDNss6NUa+V+cRVH/p39sxEadfFoVVWX/X4z7KV+yTXSxo1c xSYnVd3IwEVKomfVNwQ8UxQqKGv6BeaHsf7BWL8lrKYOqI51QnSe4apzdLbJxVNgRg6Z oWSaXR7PDrvsesWVeMB6Z5A+oH6M1t+/TCny6I2xn95i+gGmtsLupBzoR3a1OgLqTJhP cmVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791545791; x=1792150591; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LpoT01wAxSeGbAtr3r8DJqlxKzqo+vdrIEEQQ4fC6DE=; b=ZFDAyq8KPTCoU6CKI1ITz5HkrYHkVaE7TuhRvi1Am/Si//UsJ18rnugyNldVu3ugsS JiCJqhxLSChQvKIrQGyBOopi7qRm0XwbCSpfAr5S2t0ioQXUHNuCrjh2/Jxh2RYlKcg7 m8o2sLFLKYKV295kfCM0hkeJxZyQiVCVFbF6tvTBE3wwL6HBoFMfUVNbXsJaBHToVdrd DNoTA+5dhIj8xYv1GP+vLiZvbkJP875eXKcVzDbmNEXvSowDvY6sbwMsviH7KJEVBQVF iJpcFDZyoDV2aaXxrVUERm8l4V++SqKSA9i5yAMVEgkZk+pvxOm3aWaf6JDxp7fmXlHs COZQ== X-Forwarded-Encrypted: i=1; AKwUvBwRHUZC39/PB2AH2OnrP0nP6q5DrvkE9ZbrwcN+jCMTDNQrdfU2diTqVddyzdw/GJ0ONGll/kA5Zo+VzWg=@vger.kernel.org X-Gm-Message-State: AFq9FYItu5L3ueoWg3Ug6pW+sLzY5i6f8QyMVKUwSmc08J4EuvNs+xjB CBcp5mG8OmuDAm1fHHjsRKLkEcMpCpYU6RxlMvAGqD2A9R5/qSf3YVddF7e2EYOIJAPgyQ5DGGj 0RCadT0iYzjnn8CLNFnn1PAIu76Z8iM1aQajirTScYFc8eHRZ3qzwMLkfZYTY8zNgXWI= X-Gm-Gg: AYBFou1kfVrVKnXtEXLGPFFny5Qhv5YJBQMy6nT3j/X3ttvLhTBflTXF5cMyAa5vEyL gPCuGC9OKXuoZdK3CdJD9UQOGGJJ1MM3BJKrjuWxmizynL62pjC8+6OPpNSkVAEkt7bNH1k8jTf yuYiYl7G0Qxgd69dhdebZp9R8UBmHmBaVaQWuK+FTekac/8h6d6J3squQcYJK8vYZryv3+AJbv2 n1dlrNZ0V8ZL6ZGaVFmIAGrREHTDD3r9PUL/ewrJ2IBKlHb5Uu+jNfdHyQ3jatveRJjIYGX9cAu UhvnYIMryWrLx6fBFnbquvPtTBbI9Z2QLD37vpMLaArsXfhbJxIhGc47v8ZzdPa1iRWaP5+a1On rzcxGZDB58/dVhufCAdpQ8d90qXUn9Ljxf5Z18wLD6BDhsgtYf8jQZwoMB+Pa6q8= X-Received: by 2002:a17:90b:224c:b0:39e:6a80:b799 with SMTP id 98e67ed59e1d1-3ab3a8d16dbmr1720385a91.41.1791545790950; Fri, 09 Oct 2026 04:36:30 -0700 (PDT) X-Received: by 2002:a17:90b:224c:b0:39e:6a80:b799 with SMTP id 98e67ed59e1d1-3ab3a8d16dbmr1720362a91.41.1791545790450; Fri, 09 Oct 2026 04:36:30 -0700 (PDT) Received: from [192.168.1.6] ([117.143.161.217]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ab37163e21sm3634153a91.14.2026.10.09.04.36.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2026 04:36:30 -0700 (PDT) Message-ID: <9afa48c4-b5b7-43b8-80e5-d829906a2088@oss.qualcomm.com> Date: Fri, 9 Oct 2026 19:36:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v19 08/12] media: qcom: camss: vfe: Add support for VFE 1080 To: Bryan O'Donoghue , bod@kernel.org Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Abel Vesa , linux-phy@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com, Vijay Kumar Tumati , Atiya Kailany References: <20261008-kaanapali-camss-v19-0-b2c583ef50e0@oss.qualcomm.com> <20261008-kaanapali-camss-v19-8-b2c583ef50e0@oss.qualcomm.com> <179149982796.2596899.756044515233442982.b4-reply@b4> <7452d85d-83a8-493c-8d74-5020ab72982d@oss.qualcomm.com> <8a2ff836-57ce-4df6-aaae-0db3f36e8b58@linaro.org> Content-Language: en-US From: Hangxiang Ma In-Reply-To: <8a2ff836-57ce-4df6-aaae-0db3f36e8b58@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDA0NiBTYWx0ZWRfXyyl92wZAPlkr J6DRqaSvMOgv5i/CfAaBj1i4A7fbU+9X/V/cZC5rrwrPiaIzZfeGB2TOgewpsejG0juhDQ0zhlC X3Tv2lSTxz5Bsn6elIjxpFuepWayN/Y= X-Proofpoint-ORIG-GUID: 7_eVT76UMpnhZYTS6AM2tR1z1S-GjtdQ X-Proofpoint-GUID: 7_eVT76UMpnhZYTS6AM2tR1z1S-GjtdQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDA0NiBTYWx0ZWRfX5rx1HZFE0pXh yNm5JTEAxgD8EAh/hWf74EAL2hJPd2FWEjYoH0+9HZQAHCHmOztvn9DYkukU/C7glkQAxJDEeCo oAe72uHmHYNPTbKtsOvU6QpfvqzHZNpo3IA+zpL2EJlsE7jTrCJxpzhVT4t3YW7uOY77Y9tE6Jx L2TENPaqlDpiOEaFEizavkdSCRZeLYU9nCeNe9iLQJs3pCRhHr8EJLdbx3ldzyObPFg5b7O9bin NQRiLGOG+OW834ctEmlajbksNPZ1TCNRfZMG8cunmktoSI2CNdQgIWcaM4zJ6Man6rJl4J5v+ga IouDlpFW5IayaZe4Olg6KBgayl9S6U4jJXhUBmZHgkSFBrkQ/TXRuUmFR9rMHPaoNcOkfxI6qHb qz9rFWHUFV+V9qJCTYvAC6h3RV9W7bi1Rxx2MBqUJVcIJ9Vuk728Ii4c1S0J/QpFnoJbLz3/Q3T +SAjTVC+8asmHbjV0YQ== X-Authority-Analysis: v=2.4 cv=ad30Dhot c=1 sm=1 tr=0 ts=6ac8d1c0 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=K/RrOd38U9TixX+j9hIN8g==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=CGVMczJOcLXbesxPaW8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-09_03,2026-10-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610090046 On 10/9/2026 4:39 PM, Bryan O'Donoghue wrote: > On 09/10/2026 03:59, Hangxiang Ma wrote: >>>> diff --git a/drivers/media/platform/qcom/camss/Makefile b/drivers/ >>>> media/platform/qcom/camss/Makefile >>>> index 218ba3a95939..42a14e8fe1b7 100644 >>>> --- a/drivers/media/platform/qcom/camss/Makefile >>>> +++ b/drivers/media/platform/qcom/camss/Makefile >>>> @@ -26,6 +26,7 @@ qcom-camss-objs += \ >>>>           camss-vfe-340.o \ >>>>           camss-vfe-480.o \ >>>>           camss-vfe-680.o \ >>>> +        camss-vfe-1080.o \ >>> >>> Can't say I'm 1000000% clear on when reg_update() is supposed to >>> happen in >>> the flow of the logic you have here. >>> >>> I'm a bit suspicious of adding a new flag which skips the update but >>> assumes some other bit of code executes later and does that update. >>> >>> Can you explain this some more please. >>> >> >> Thanks for the review. These points were discussed in an earlier >> revision, but I should have explained them directly in this version. >> >> Vijay once clarified that the configuration principle became more >> strict since Kaanapali. We can back to > all/662a21a3- de8b-406f-a15d-b8a572aa79ab@oss.qualcomm.com/> for more >> details. >> >> In short, the hardware guidance asks to issue the REG_UPDATE after all >> of the CSID configuration registers are written. Kaanapali seems to >> have very strict dependency in the hardware about this sequence and >> with the original sequence, no RUP DONE or BUF DONE events are >> received at all. While other chipsets can work normally. > > But how/where are we saying that happens ? > > --- > bod Hi Bryan, When reg_update_after_csid_config is set, vfe_enable_output_v2() loads the buffers but skips reg_update. The RUP is written later from csid_configure_stream(), after the RX and RDI configuration. On stream start: video_start_streaming() s_stream(1) on VFE <- walked upstream from video node vfe_enable_output_v2() <- only load buffers, no reg_update s_stream(1) on CSID csid_set_stream() csid_configure_stream() <- if need_vc_update, else not program RX config for each VC: program RDI and RX VC config AUP + RUP (__csid_reg_update covers both) RDI_CTRL start On this path the VFE reg_update is itself a CSID write, CSID_AUP_CMD and RUP_SET in csid_subdev_reg_update(), not a VFE register write. RUP goes in after the configuration writes. Only the RDI_CTRL start command follows it. The video streaming function walks the pipeline upstream from the video node and calls s_stream(1) on each subdev in turn, so the VFE is always started before the CSID. What isn't obvious is that vfe_enable_output_v2() depends on that order to get its RUP issued at all. On Kaanapali, REG_UPDATE has to come after the CSID configuration is written, otherwise no RUP DONE or BUF DONE is seen. I haven't reproduced the failure case myself as no BUF_DONE count mismatch and frame missing events are observed. So I think the information get from hardware guidance should be reliable. Thanks. --- Best Regards, Hangxiang