From: Justin Chen <justin.chen@broadcom.com>
To: Markus Elfring <Markus.Elfring@web.de>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net] net: bcmasp: fix memory leak when bringing down if
Date: Mon, 15 Apr 2024 10:36:37 -0700 [thread overview]
Message-ID: <9afad2b3-38a5-470d-a66f-10aa2cba3bab@broadcom.com> (raw)
In-Reply-To: <6881c322-8fbb-422f-bdbb-392a83d0b326@web.de>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On 4/14/24 4:23 AM, Markus Elfring wrote:
> Can it be nicer to use the word “interface” instead of “if”
> in the summary phrase?
>
"if" for interface is a term used in the network stack, but I can see
why it is confusing. Can submit a v2.
>
>> When bringing down the TX rings we flush the rings but forget to
>> reclaimed the flushed packets. This lead to a memory leak since we
>> do not free the dma mapped buffers. …
>
> I find this change description improvable.
>
> * How do you think about to avoid typos?
>
> * Would another imperative wording be more desirable?
>
The change description makes sense to me. Can you be a bit more specific
as to what isn't clear here?
Thanks,
Justin
> Regards,
> Markus
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]
next prev parent reply other threads:[~2024-04-15 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 18:16 Justin Chen
2024-04-12 21:09 ` Florian Fainelli
2024-04-14 11:23 ` Markus Elfring
2024-04-15 17:36 ` Justin Chen [this message]
2024-04-15 19:46 ` Markus Elfring
2024-04-17 16:19 ` Simon Horman
2024-04-17 16:52 ` Florian Fainelli
2024-04-17 18:48 ` Justin Chen
2024-04-18 0:56 ` Jakub Kicinski
2024-04-17 20:34 ` Simon Horman
2024-04-18 8:02 ` net: bcmasp: Patch review challenges Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9afad2b3-38a5-470d-a66f-10aa2cba3bab@broadcom.com \
--to=justin.chen@broadcom.com \
--cc=Markus.Elfring@web.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®