From: Randy Dunlap <rdunlap@infradead.org>
To: poeschel@lemonage.de,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] auxdisplay: hd44780_common: Fix build error
Date: Mon, 9 Nov 2020 09:30:17 -0800 [thread overview]
Message-ID: <9afaeba0-6e83-cdc2-07f8-3bac5553208b@infradead.org> (raw)
In-Reply-To: <20201109093154.1080024-1-poeschel@lemonage.de>
On 11/9/20 1:31 AM, poeschel@lemonage.de wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
>
> When building the hd44780_common driver without a driver that actually
> uses it like panel or hd44780 you got a build error, because
> hd44780_common uses charlcd, but did not select it. It's users did
> select it.
> This is fixed now. hd4478_common now selects charlcd in Kconfig and
> panel and hd44780 do not. They only select hd44780_common.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/auxdisplay/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index a69623124a26..a2b59b84bb88 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -27,6 +27,7 @@ config CHARLCD
>
> config HD44780_COMMON
> tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST
> + select CHARLCD
> help
> This is a module with the common symbols for HD44780 (and compatibles)
> displays. This is the code that multiple other modules use. It is not
> @@ -37,7 +38,6 @@ config HD44780_COMMON
> config HD44780
> tristate "HD44780 Character LCD support"
> depends on GPIOLIB || COMPILE_TEST
> - select CHARLCD
> select HD44780_COMMON
> help
> Enable support for Character LCDs using a HD44780 controller.
> @@ -196,7 +196,6 @@ config ARM_CHARLCD
> menuconfig PARPORT_PANEL
> tristate "Parallel port LCD/Keypad Panel support"
> depends on PARPORT
> - select CHARLCD
> select HD44780_COMMON
> help
> Say Y here if you have an HD44780 or KS-0074 LCD connected to your
>
--
~Randy
next prev parent reply other threads:[~2020-11-09 17:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 9:58 [PATCH v6 00/25] Make charlcd device independent poeschel
2020-11-03 9:58 ` [PATCH v6 01/25] auxdisplay: Use an enum for charlcd backlight on/off ops poeschel
2020-11-03 9:58 ` [PATCH v6 02/25] auxdisplay: Introduce hd44780_common.[ch] poeschel
2020-11-03 9:58 ` [PATCH v6 03/25] auxdisplay: Move hwidth and bwidth to struct hd44780_common poeschel
2020-11-03 9:58 ` [PATCH v6 04/25] auxdisplay: Move ifwidth " poeschel
2020-11-03 9:58 ` [PATCH v6 05/25] auxdisplay: Move write_data pointer to hd44780_common poeschel
2020-11-03 9:58 ` [PATCH v6 06/25] auxdisplay: Move write_cmd pointers to hd44780 drivers poeschel
2020-11-03 9:58 ` [PATCH v6 07/25] auxdisplay: Move addr out of charlcd_priv poeschel
2020-11-03 9:58 ` [PATCH v6 08/25] auxdisplay: hd44780_common_print poeschel
2020-11-03 9:58 ` [PATCH v6 09/25] auxdisplay: provide hd44780_common_gotoxy poeschel
2020-11-03 9:58 ` [PATCH v6 10/25] auxdisplay: add home to charlcd_ops poeschel
2020-11-03 9:58 ` [PATCH v6 11/25] auxdisplay: Move clear_display to hd44780_common poeschel
2020-11-03 9:58 ` [PATCH v6 12/25] auxdisplay: make charlcd_backlight visible " poeschel
2020-11-03 9:58 ` [PATCH v6 13/25] auxdisplay: Make use of enum for backlight on / off poeschel
2020-11-03 9:58 ` [PATCH v6 14/25] auxdisplay: Move init_display to hd44780_common poeschel
2020-11-03 9:58 ` [PATCH v6 15/25] auxdisplay: implement various hd44780_common_ functions poeschel
2020-11-03 9:58 ` [PATCH v6 16/25] auxdisplay: cleanup unnecessary hd44780 code in charlcd poeschel
2020-11-03 9:58 ` [PATCH v6 17/25] auxdisplay: Move char redefine code to hd44780_common poeschel
2020-11-03 9:58 ` [PATCH v6 18/25] auxdisplay: Call charlcd_backlight in place poeschel
2020-11-03 9:58 ` [PATCH v6 19/25] auxdisplay: hd44780_common: Reduce clear_display timeout poeschel
2020-11-03 9:58 ` [PATCH v6 20/25] auxdisplay: hd44780: Remove clear_fast poeschel
2020-11-03 9:58 ` [PATCH v6 21/25] auxdisplay: charlcd: replace last device specific stuff poeschel
2020-11-03 9:58 ` [PATCH v6 22/25] auxdisplay: Change gotoxy calling interface poeschel
2020-11-03 9:58 ` [PATCH v6 23/25] auxdisplay: charlcd: Do not print chars at end of line poeschel
2020-11-03 9:58 ` [PATCH v6 24/25] auxdisplay: lcd2s DT binding doc poeschel
2020-11-03 9:58 ` [PATCH v6 25/25] auxdisplay: add a driver for lcd2s character display poeschel
2020-11-04 13:30 ` [PATCH v6 00/25] Make charlcd device independent Miguel Ojeda
2020-11-06 10:11 ` Lars Poeschel
2020-11-06 12:17 ` Miguel Ojeda
2020-11-06 16:35 ` Randy Dunlap
2020-11-09 9:31 ` [PATCH] auxdisplay: hd44780_common: Fix build error poeschel
2020-11-09 9:45 ` Miguel Ojeda
2020-11-09 17:30 ` Randy Dunlap [this message]
2020-11-09 9:53 ` [PATCH v6 00/25] Make charlcd device independent Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9afaeba0-6e83-cdc2-07f8-3bac5553208b@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=poeschel@lemonage.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®