From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B3B6C433FE for ; Tue, 11 Oct 2022 12:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229563AbiJKMG1 (ORCPT ); Tue, 11 Oct 2022 08:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbiJKMGX (ORCPT ); Tue, 11 Oct 2022 08:06:23 -0400 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B58F8D0D6 for ; Tue, 11 Oct 2022 05:06:15 -0700 (PDT) Received: by mail-qk1-x734.google.com with SMTP id f27so666660qkh.12 for ; Tue, 11 Oct 2022 05:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AVRPkDEbACvmkZC8kApIS7yMdkHthYtuVHRwDkmsTFY=; b=NhH0A06ZPTKy45tcwzqP78rP8uzdihSRJD6UVIGQ2MBlCI+YSqrT1HQVWUnG8YAcAz gPj/dwH7zowzWBnlmrUG0QyMpQEWPR1mid7e0+IeeTlzWVubMTzwtKjlqtpEAVEPnesJ RE4rWeqdhXj4NMbVcXvcXxueWvvP+HJ7QmW/i93RLKOenyQmJ+7YrXQaCTWII3oF2LEs AQ+4sKPQSqXi4e4IvbmQ24fUD2rpEw7Jf/10Pbc7VtClMuNVy8p2YvX4ZF5JvyAYac8M OVgtlrgxYEytL0G7Itva+hbTYfuZDSINva/G24TC48CsG3eR1P84ktPC750qZSZnGFB6 ZSHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AVRPkDEbACvmkZC8kApIS7yMdkHthYtuVHRwDkmsTFY=; b=BLQSF/0DNuO6hsqqP+QuLpCipzSlmWCSddG22nJBp238V3LiiUx1dPErjvbucyh6PM YQXJkLi0iF3sgFbpn0RGylSURx+9ilTl5VbyrpiHrLDcVqXzpm3lwoAco9bxjTdxyZy7 5IPFCbLcYlQiE+GhKamVk1qD+4Umzo/bqoNH959Ri4by7e4eVd1fmSZdA35saw5g51tZ QJYEYhi9QaAO1Hhq+FXvJJidYnqtx6Kfzfq0vZN3+0uCX4DDswl9z+0upDrWJpd5T0mb Exztt1w5H2R/gDn+QwirYGRCDlZU4OjIAKwAdYXzrcUc/Vch95v8cREc8tYNtarvU/MY uScQ== X-Gm-Message-State: ACrzQf1Zh9LQNDWhfch7+E1Mv/+v5JxDWcLIZvn9ZQC4W2N3FrV2KRbo SX11JjH9eIuylNhtydq6g54CIw== X-Google-Smtp-Source: AMsMyM6OjIpqGMDaEgzj3/3BoL+9VrEq3Jr15zfY2zwCSrdjnFPPz0n+ElpXLJIs9GfTLc4SnGylRQ== X-Received: by 2002:a05:620a:1b9b:b0:6ed:35f0:9b56 with SMTP id dv27-20020a05620a1b9b00b006ed35f09b56mr5955854qkb.196.1665489974107; Tue, 11 Oct 2022 05:06:14 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id b26-20020a05620a089a00b006ce3cffa2c8sm3428470qka.43.2022.10.11.05.06.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 05:06:12 -0700 (PDT) Message-ID: <9afce114-1a0e-a0be-c07b-a78740e2f108@linaro.org> Date: Tue, 11 Oct 2022 08:03:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators Content-Language: en-US To: Alexandre Mergnat Cc: broonie@kernel.org, chen.zhong@mediatek.com, devicetree@vger.kernel.org, dmitry.torokhov@gmail.com, fparent@baylibre.com, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, robh+dt@kernel.org, robh@kernel.org References: <972ba839-2fd3-2b45-3477-0c7e3d32f149@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <972ba839-2fd3-2b45-3477-0c7e3d32f149@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/2022 05:30, Alexandre Mergnat wrote: > Hi Krzysztof, > > Thanks for your review ! > > >> + > >> +    properties: > >> +      regulator-name: > >> +        pattern: "^v(core|modem|pa|proc|s1)$" > > > > Why enforcing particular name of the regulator? > > The regulator names are forced to match with the datasheet names. > > I think it's a good practice to increase visibility between HW & SW. Enforcing is not a good practice. > > Also, that keep consistency with other Mediatek PMIC schema. So there is a bad practice and instead of fixing it, you align to it... No. Best regards, Krzysztof