From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Richard Acayan <mailingradian@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org, konrad.dybcio@somainline.org,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, tdas@codeaurora.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, caleb@connolly.tech,
jo@jsfamily.in
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: gcc-sdm845: add sdm670 global clocks
Date: Fri, 9 Sep 2022 09:14:43 +0200 [thread overview]
Message-ID: <9b009a58-5a2b-1276-49de-3c4f93b2f356@linaro.org> (raw)
In-Reply-To: <20220908230102.207682-1-mailingradian@gmail.com>
On 09/09/2022 01:01, Richard Acayan wrote:
>>> + clock-names:
>>> + items:
>>> + - const: bi_tcxo
>>> + - const: bi_tcxo_ao
>>> + - const: sleep_clk
>>> + - const: pcie_0_pipe_clk
>>> + - const: pcie_1_pipe_clk
>>
>> Blank line here.
>>
>> With this:
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Thanks for reviewing. While I'm at it, I might as well swap sdm670 and
> sdm845 if statements so they're at least in the same order as in the enum
> (I don't know what order to put them in).
Put them in alphabetical order.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-09 7:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 22:39 [PATCH v2 0/3] SDM670 Global Clocks Richard Acayan
2022-09-07 22:39 ` [PATCH v2 1/3] dt-bindings: clock: gcc-sdm845: add sdm670 global clocks Richard Acayan
2022-09-08 11:07 ` Krzysztof Kozlowski
2022-09-08 23:01 ` Richard Acayan
2022-09-09 7:14 ` Krzysztof Kozlowski [this message]
2022-09-07 22:39 ` [PATCH v2 2/3] clk: qcom: gcc-sdm845: use device tree match data Richard Acayan
2022-09-08 11:08 ` Krzysztof Kozlowski
2022-09-07 22:39 ` [PATCH v2 3/3] clk: qcom: gcc-sdm845: add sdm670 global clock data Richard Acayan
2022-09-08 11:10 ` Krzysztof Kozlowski
2022-09-08 23:02 ` Richard Acayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b009a58-5a2b-1276-49de-3c4f93b2f356@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=jo@jsfamily.in \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®