From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Haotian Zhang <vulab@iscas.ac.cn>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: codecs: va-macro: fix resource leak in probe error path
Date: Thu, 6 Nov 2025 15:58:27 +0100 [thread overview]
Message-ID: <9b024347-21ec-426c-b783-1a9351fc248c@oss.qualcomm.com> (raw)
In-Reply-To: <20251106143114.729-1-vulab@iscas.ac.cn>
On 11/6/25 3:31 PM, Haotian Zhang wrote:
> In the commit referenced by the Fixes tag, clk_hw_get_clk()
> was added in va_macro_probe() to get the fsgen clock,
> but forgot to add the corresponding clk_put() in va_macro_remove().
> This leads to a clock reference leak when the driver is unloaded.
>
> Switch to devm_clk_hw_get_clk() to automatically manage the
> clock resource.
>
> Fixes: 30097967e056 ("ASoC: codecs: va-macro: use fsgen as clock")
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
I feel like that's a little much given you found the original issue
and I only suggested a different way to tackle it, but regardless:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-11-06 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 7:50 [PATCH] " Haotian Zhang
2025-11-06 10:00 ` Konrad Dybcio
2025-11-06 14:31 ` [PATCH v2] " Haotian Zhang
2025-11-06 14:58 ` Konrad Dybcio [this message]
2025-11-06 15:59 ` Mark Brown
2025-11-06 23:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b024347-21ec-426c-b783-1a9351fc248c@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®