Re: [PATCH 04/11] dt-bindings: usb: Add NVIDIA LSTP USB adapter

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/10/2026 19:36, Adrian Ambrozewicz wrote:
> +  - $ref: /schemas/usb/usb-device.yaml#
> +  - $ref: "#/$defs/channels"
> +  - if:
> +      properties:
> +        "#address-cells":
> +          const: 1
> +    then:
> +      patternProperties:
> +        "^interface@": false
> +    else:
> +      patternProperties:
> +        "^(spi|i2c|gpio|serial|ipmi)@": false

No, compatible, not presence of properties defines whether device has
SPI or not.

Also, allOf is placed after required, see other schemas or example-schema.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - usb955,cf11
> +      - usb424,4940
> +      - usb174c,2214
> +
> +  reg:
> +    description: Port number on the parent hub or host controller.
> +    maxItems: 1
> +
> +  "#address-cells":
> +    enum: [1, 2]
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  "^interface@[0-9a-f]{1,2}(,[0-9a-f]{1,2})?$":
> +    type: object

Your example is either incomplete or this is unnecessary. Assuming your
example is complete, then you have one interface, thus this node is
pointless. What's more, your top level compatible EXACTLY defines all
this, thus none of your properties are needed as they are implied by the
top-level compatible.

Best regards,
Krzysztof