From: Guenter Roeck <linux@roeck-us.net>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: dp83640: Drop unused PAGE0 define
Date: Thu, 16 Sep 2021 13:10:53 -0700 [thread overview]
Message-ID: <9b07c181-d039-eda0-d623-4e791bb2a43f@roeck-us.net> (raw)
In-Reply-To: <20210916195055.1694099-1-linux@roeck-us.net>
On 9/16/21 12:50 PM, Guenter Roeck wrote:
> parisc:allmodconfig fails to build with the following error.
>
> In file included from drivers/net/phy/dp83640.c:23:
> drivers/net/phy/dp83640_reg.h:8: error: "PAGE0" redefined
>
> The dp83640 driver does not use this define, so just remove it.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/net/phy/dp83640_reg.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/phy/dp83640_reg.h b/drivers/net/phy/dp83640_reg.h
> index 21aa24c741b9..601e8d107723 100644
> --- a/drivers/net/phy/dp83640_reg.h
> +++ b/drivers/net/phy/dp83640_reg.h
> @@ -5,7 +5,6 @@
> #ifndef HAVE_DP83640_REGISTERS
> #define HAVE_DP83640_REGISTERS
>
> -#define PAGE0 0x0000
> #define PHYCR2 0x001c /* PHY Control Register 2 */
>
> #define PAGE4 0x0004
>
Sorry for the noise. I just learned that the problem is already fixed.
Guenter
prev parent reply other threads:[~2021-09-16 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 19:50 Guenter Roeck
2021-09-16 20:10 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b07c181-d039-eda0-d623-4e791bb2a43f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®