mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
	Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com,
	prasad.kumpatla@oss.qualcomm.com, ajay.nandam@oss.qualcomm.com
Subject: Re: [RESEND PATCH v4 0/3] Fix lpaif_type and DAI configuration for I2S interface
Date: Fri, 19 Sep 2025 11:51:24 +0200	[thread overview]
Message-ID: <9b0ace7d-2330-4152-b88c-b5d6ccb90b39@linaro.org> (raw)
In-Reply-To: <20250911063612.2242184-1-mohammad.rafi.shaik@oss.qualcomm.com>

On 11/09/2025 08:36, Mohammad Rafi Shaik wrote:
> Fix the lpaif_type configuration for the I2S interface.
> The proper lpaif interface type required to allow DSP to vote
> appropriate clock setting for I2S interface and also Add support
> for configuring the DAI format on MI2S interfaces to allow setting
> the appropriate bit clock and frame clock polarity, ensuring correct
> audio data transmissionover MI2S.
> 
> changes in [v4]:
> 	- Updated commit message in patch v4-0003, suggested by Srinivas Kandagatla.
> 	- Link to V3: https://lore.kernel.org/linux-sound/20250905150445.2596140-1-mohammad.rafi.shaik@oss.qualcomm.com/
> 
> changes in [v3]:
> 	- Added Cc: <stable@vger.kernel.org>, suggested by Srinivas Kandagatla.
> 	- Added QUINARY MI2S case in patch 3, suggested by Konrad.
> 	- Link to V2: https://lore.kernel.org/lkml/20250905104020.2463473-1-mohammad.rafi.shaik@oss.qualcomm.com/
> 
> changes in [v2]:
> 	- Used snd_soc_dai_set_fmt() API to set the current clock settings,
> 	  instead of the default WS source setting, as suggested by Srinivas Kandagatla.
> 	- Link to V1: https://lore.kernel.org/lkml/20250822171440.2040324-1-mohammad.rafi.shaik@oss.qualcomm.com/
> 
> Mohammad Rafi Shaik (3):
>    ASoC: qcom: audioreach: Fix lpaif_type configuration for the I2S
>      interface
>    ASoC: qcom: q6apm-lpass-dais: Fix missing set_fmt DAI op for I2S
>    ASoC: qcom: sc8280xp: Enable DAI format configuration for MI2S
>      interfaces
> 
>   sound/soc/qcom/qdsp6/audioreach.c       | 1 +
>   sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 1 +
>   sound/soc/qcom/sc8280xp.c               | 4 ++++
>   3 files changed, 6 insertions(+)
> 

Fixes a long-term issue I had with I2S with audioreach platforms, thanks!

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK

Neil

      parent reply	other threads:[~2025-09-19  9:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11  6:36 Mohammad Rafi Shaik
2025-09-11  6:36 ` [RESEND PATCH v4 1/3] ASoC: qcom: audioreach: Fix lpaif_type configuration for the " Mohammad Rafi Shaik
2025-09-11  6:36 ` [RESEND PATCH v4 2/3] ASoC: qcom: q6apm-lpass-dais: Fix missing set_fmt DAI op for I2S Mohammad Rafi Shaik
2025-09-11  6:36 ` [RESEND PATCH v4 3/3] ASoC: qcom: sc8280xp: Enable DAI format configuration for MI2S interfaces Mohammad Rafi Shaik
2025-09-16  4:12   ` Alexey Klimov
2025-09-11 11:18 ` [RESEND PATCH v4 0/3] Fix lpaif_type and DAI configuration for I2S interface Mark Brown
2025-09-19  9:51 ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b0ace7d-2330-4152-b88c-b5d6ccb90b39@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=ajay.nandam@oss.qualcomm.com \
    --cc=broonie@kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mohammad.rafi.shaik@oss.qualcomm.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=prasad.kumpatla@oss.qualcomm.com \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®