From: Stephen Boyd <sboyd@kernel.org>
To: David Hunter <david.hunter.linux@gmail.com>, mturquette@baylibre.com
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
javier.carrasco.cruz@gmail.com, shuah@kernel.org,
david.hunter.linux@gmail.com
Subject: Re: [PATCH 1/1] Driver: clk-qoriq.c: replace of_node_put with _free improves cleanup
Date: Tue, 20 Aug 2024 15:03:24 -0700 [thread overview]
Message-ID: <9b1107439ffd3fe3cf4945a500a881c8.sboyd@kernel.org> (raw)
In-Reply-To: <20240820013550.4906-1-david.hunter.linux@gmail.com>
Quoting David Hunter (2024-08-19 18:35:49)
> Use the _free function to have automatic clean up instead of calling
How about:
Use __free() to have automatic cleanup instead of calling
of_node_put() manually.
> another function, of_node_put. This prevents leaking reference counts.
Are there any leaking reference counts? I'd just omit that sentence
unless there is one.
>
> The following commit has information on _free(device_node):
>
> 9448e55d032d99af8e23487f51a542d51b2f1a48
>
> The code was able to compile without errors or warnings.
The rest of this can go below the triple dash ---
next prev parent reply other threads:[~2024-08-20 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 1:35 David Hunter
2024-08-20 22:03 ` Stephen Boyd [this message]
2024-08-21 1:07 ` [PATCH 1/1 V2] " David Hunter
2024-08-28 0:03 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b1107439ffd3fe3cf4945a500a881c8.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®