From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Mark Brown <broonie@kernel.org>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Vijendar.Mukunda@amd.com, linux-sound@vger.kernel.org,
venkataprasad.potturu@amd.com, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com, kernel@gpiccoli.net,
Mario Limonciello <mario.limonciello@amd.com>,
Robert Beckett <bob.beckett@collabora.com>,
Umang Jain <uajain@igalia.com>, Melissa Wen <mwen@igalia.com>
Subject: Re: [PATCH] ASoC: amd: acp: Add DMI quirk for Valve Steam Deck OLED
Date: Thu, 23 Apr 2026 15:37:23 -0300 [thread overview]
Message-ID: <9b11564e-bb1c-b606-4968-9fcecb10c181@igalia.com> (raw)
In-Reply-To: <823eb16f-339a-499a-9fb1-27a166f8838d@sirena.org.uk>
On 22/04/2026 09:14, Mark Brown wrote:
> On Tue, Apr 21, 2026 at 05:23:08PM -0300, Guilherme G. Piccoli wrote:
>
>>>> +/* List of DMI quirks - check acp-mach-common.c for usage. */
>>>> +#define TDM_MODE_ENABLE 1
>>>> +#define REMAP_DMIC_BT 2
>
>>> Since the list of quirks may grow over time, it might be worth differentiating
>>> these macros from the common ones — either by adding a `QUIRK_` prefix (or
>>> similar), or better yet, turning them into an enum?!
>
>> Hi Cristian! Thanks for the suggestion, I'm OK either way, let's see
>> what maintainers prefer and I can easily spin a V2 with such change.
>
> I think Cristian's suggestions make sense.
Thanks!
Closing the loop, V2 posted here:
https://lore.kernel.org/r/20260423183505.116445-1-gpiccoli@igalia.com/
prev parent reply other threads:[~2026-04-23 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 19:17 Guilherme G. Piccoli
2026-04-21 19:24 ` Mario Limonciello
2026-04-21 20:18 ` Cristian Ciocaltea
2026-04-21 20:23 ` Guilherme G. Piccoli
2026-04-22 12:14 ` Mark Brown
2026-04-23 18:37 ` Guilherme G. Piccoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b11564e-bb1c-b606-4968-9fcecb10c181@igalia.com \
--to=gpiccoli@igalia.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=bob.beckett@collabora.com \
--cc=broonie@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mwen@igalia.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=uajain@igalia.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®