From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0314F3DB306 for ; Wed, 3 Jun 2026 15:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780502038; cv=none; b=HgIvg4KWjGAOOC6gdmkUBth7SyChP8DXJ4k9x7c1xvVIMrX73467TwZITP3pzGJmS5VK/3s0+Ll/4zuMDuX+oLzPsFu1XBpc/vTVCFqJETmbZDcVuBTbbP6dxcHF02OWO8na4isPWjLqekq5BteI/l5mRqI9ih9Ztl6gcw1LkYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780502038; c=relaxed/simple; bh=YyHIKl0YFnOrf4b3X6aHRwQh3XkLsdrmrGiOM+ixt8g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KuOUFdNo0LLsMYFsP+FeqFNJDSQ1r458KmPS4SdQDGIfo4MGyiECxsBzGYF8VM8u+aFW1e2G2ONtT2tbPWrp29VesxD6RpwB9pj9rtS5kB+Iw4HZYGd4vJ+wUDJcDss9w/mXjdM4mnMQV6tMw3ta9xOOMeLlyuTRcYCNoTUPjt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H2gylKza; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H2gylKza" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-45ef29c5561so3236970f8f.0 for ; Wed, 03 Jun 2026 08:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780502035; x=1781106835; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WeNxgthX7RDeq1y4GZbJjfxu5vLqCNfeHjKxVMHovlQ=; b=H2gylKzanBFzLlh0QwLhFCoTA9kmMu3xckPfj00m/AgWY08AMjxKyC1tbGP6AclfHK f6TqEp9VWlEqppmCKNjh1j54ERThV1uT3XwIr1S0UZqxrf8dJJKvNcHMWpTDcomNdDQT 1ugep2Umk0xBkrTavpX9EezveY2qnMdLmfvob/JzOcWCpNhaVgJnTCClBZYpREYU0J4W QP4QxYz0US7umplCbTx/sxwVHNmdJ7SxmFYTzRGf4odh2x/OXtv9GSeKpBUmKODYnMMd 8tNawXfMv87ZsCsx89KD1c2PnM4fPWp5r+plId3uuSdVa7ykpV3QOT+Ct0pL9Ep2VF+H Ttsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780502035; x=1781106835; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WeNxgthX7RDeq1y4GZbJjfxu5vLqCNfeHjKxVMHovlQ=; b=AT0zojVDeb8ZCjIFeivj+cYPyyGTzIEHZMPwEKcN1QOvVO479bO/kqTYGxE99cLOtG +i3gShgfTJ2oqx5h8amXQWyvwzMu9ASRYeLqLozep3cDoeXHHjfJr++vMnKMaFku/WtV OpyCLudTVWEa0311BVI7GjeYDjfRtDgferXr6m430TmYchoCg/nRoQtl5P8op6O5ey2l J9HSQl5iQoxvHBoLmUIAzRiwxHEGDYt9ZJcSWmoy4Y8VjgEFpdeqcVDY2pfUjW0Rh5uH HAJml2gOr3sZu/t2fqRzpEhE2hLqJzxsECcbYGZwhvC3s11fJ9ZNYtYOn1yV+zFedxrx 6gnA== X-Forwarded-Encrypted: i=1; AFNElJ9D8eIxdQtFQGaxecRmASMAJoK7VPjczmwal17xRM9gwpx64lPym+bxcrrP9h6D8FejEtkn1qtyKU/beGE=@vger.kernel.org X-Gm-Message-State: AOJu0YxljME28dWX5wJVUh3v6TNIMKiASqX7InbvYQWma9MrmsKqNBKU 6KlcITmmvi4rcDDzcl21RVr/G8j101bX54CGyYjzxJ9VflsmfDRTZTvMwke39AHib+U= X-Gm-Gg: Acq92OGyVfbXlhIAvYvLYpkYw52+hjN5iGDhxVOftPPyLFChXA5BdIamb6n0TBRwHnJ zj7u6s+0Gtn+ioLK2eBh5LJaxKuFCY02sFgrtbaADrxRfbCmO5ZhEjsCYLXCagv6YLHGVMczZA5 yt51sx0NiB2qDM6zTeiqwU++Y0cksfBBB+v1B4veJJsz4T91yHLsWbJA2ntxUYOjrKyBlrJgASo HGXAMQy/drBiI9JxLluR0ukoi+yVUrGzwh1nExlGcdNlIgsOFpCSUXPsvd0siCQ6omqY7XPDhy1 FCrBKXvdM3EVHANceh52Z3H8YrCEFxediiQeHIfFXfuJ7I8oSnElnQpG1fnuBPcTT4Kz7xPZ2fX DLbp5xuf3smmiOSO5BlDvt9zWVXV5GbK+orr8nr2DgbgKj0Svf3YwI1TlUiev56V2jjM7dyzIJ4 kR35hFCEHiSXbnCnfRS+W550KXgTxgUZ7jM7xXpb8= X-Received: by 2002:a05:6000:2990:20b0:460:25f3:b25a with SMTP id ffacd0b85a97d-46025f3b73emr1462864f8f.34.1780502035457; Wed, 03 Jun 2026 08:53:55 -0700 (PDT) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f344148sm8692402f8f.19.2026.06.03.08.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 08:53:54 -0700 (PDT) Message-ID: <9b149f11-3e05-4871-92a0-d0fe1ec49357@linaro.org> Date: Wed, 3 Jun 2026 16:53:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/18] perf test: Add deterministic workload To: Leo Yan Cc: Suzuki K Poulose , Mike Leach , Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Amir Ayupov , Jonathan Corbet , Shuah Khan , Paschalis Mpeis , coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org References: <20260602-james-cs-context-tracking-fix-v2-0-85b5ce6f55c6@linaro.org> <20260602-james-cs-context-tracking-fix-v2-5-85b5ce6f55c6@linaro.org> <20260603112742.GT101133@e132581.arm.com> <20260603134339.GU101133@e132581.arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20260603134339.GU101133@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/06/2026 2:43 pm, Leo Yan wrote: > On Wed, Jun 03, 2026 at 02:10:37PM +0100, James Clark wrote: >> >> >> On 03/06/2026 12:27 pm, Leo Yan wrote: >>> On Tue, Jun 02, 2026 at 03:26:47PM +0100, James Clark wrote: >>> >>> [...] >>> >>>> @@ -22,3 +23,4 @@ CFLAGS_brstack.o = -g -O0 -fno-inline -U_FORTIFY_SOURCE >>>> CFLAGS_datasym.o = -g -O0 -fno-inline -U_FORTIFY_SOURCE >>>> CFLAGS_traploop.o = -g -O0 -fno-inline -U_FORTIFY_SOURCE >>>> CFLAGS_inlineloop.o = -g -O2 >>>> +CFLAGS_deterministic.o = -g -O0 >>> >>> I have no strong opinion for using 'noinline' in source or using the >>> global option '-fno-inline', just thought this is not easy to follow >>> up if anyone (likely myself) will write a new workload for disabling >>> inline. Could we have consistent style for this? >>> >>> For the patch itself: >>> >>> Reviewed-by: Leo Yan >> >> Actually it's a fair question why some have -fno-inline and others do it in >> the code, it could just be copied from when these were built by their shell >> script tests. From a quick look I would say we can easily drop the >> -fno-inline and do it in the code, and it's better to only noinline what's >> needed rather than everything. But that's probably a change for another >> time. > > Seems to me, `-fno-inline` is more reliable. > > I.e., in this patch deterministic() has no 'noinline' annotation, my > understanding is the test expects it is not inlined. With `-fno-inline` > flag, we don't need to worry anything is missed. > > Thanks, > Leo Ok I can replace the noinlines with -fno-inline then.