From: MD Danish Anwar <danishanwar@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Simon Horman <horms@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>, Diogo Ivo <diogo.ivo@siemens.com>,
Roger Quadros <rogerq@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <srk@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper functions to configure FDB
Date: Tue, 28 May 2024 10:57:33 +0530 [thread overview]
Message-ID: <9b16c10c-a08a-4b37-8ffc-6ae19b1c70d2@ti.com> (raw)
In-Reply-To: <3cf97632-4d77-4f28-bed6-7d40d61d958f@lunn.ch>
On 28/05/24 3:34 am, Andrew Lunn wrote:
>> +struct mgmt_cmd {
>> + u8 param;
>> + u8 seqnum;
>> + u8 type;
>> + u8 header;
>> + u32 cmd_args[3];
>> +} __packed;
>
> There is a general dislike for __packed. Since your structures are
> naturally well aligned, it is probably not needed. You could be
> paranoid and add BUILD_BUG_ON(sizeof(struct mgmt_cmd) != 16);
>
Sure, I will drop __packed as it's not needed and send next revision.
> Andrew
--
Thanks and Regards,
Danish
next prev parent reply other threads:[~2024-05-28 5:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 5:27 [PATCH net-next v5 0/3] Introduce switch mode support for ICSSG driver MD Danish Anwar
2024-05-27 5:27 ` [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper functions to configure FDB MD Danish Anwar
2024-05-27 22:04 ` Andrew Lunn
2024-05-28 5:27 ` MD Danish Anwar [this message]
2024-05-27 5:27 ` [PATCH net-next v5 2/3] net: ti: icssg-switch: Add switchdev based driver for ethernet switch support MD Danish Anwar
2024-05-27 22:14 ` Andrew Lunn
2024-05-27 5:27 ` [PATCH net-next v5 3/3] net: ti: icssg-prueth: Add support for ICSSG switch firmware MD Danish Anwar
2024-05-27 22:14 ` Andrew Lunn
2024-05-28 5:28 ` MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b16c10c-a08a-4b37-8ffc-6ae19b1c70d2@ti.com \
--to=danishanwar@ti.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=schnelle@linux.ibm.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®