From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Samiullah Khawaja <skhawaja@google.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<intel-wired-lan@lists.osuosl.org>, <willemb@google.com>,
<almasrymina@google.com>, David Decotigny <decot@google.com>,
Anjali Singhai <anjali.singhai@intel.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<emil.s.tantilov@intel.com>
Subject: Re: [PATCH iwl-next] idpf: set napi for each TX and RX queue
Date: Fri, 18 Jul 2025 15:06:48 +0200 [thread overview]
Message-ID: <9b1b668e-19a0-4191-a5c7-686e05a08a80@intel.com> (raw)
In-Reply-To: <efbcade2-ca5a-43ad-9512-846be207eb56@intel.com>
From: Tony Nguyen <anthony.l.nguyen@intel.com>
Date: Thu, 17 Jul 2025 13:25:05 -0700
>
>
> On 7/16/2025 2:12 PM, Samiullah Khawaja wrote:
>> Use netif_queue_set_napi to associate TX/RX queues to the relevant napi.
>> This allows fetching napi for a TX or RX queue using netlink queue-get
>> op.
>>
>> Tested:
>> python3 tools/net/ynl/pyynl/cli.py \
>> --spec Documentation/netlink/specs/netdev.yaml \
>> --do queue-get --json '{"ifindex": 3, "type": "rx", "id": 2}'
>> {'id': 2, 'ifindex': 3, 'napi-id': 515, 'type': 'rx'}
>
> Hi Samiullah,
>
> Thanks for the patch. We do, however, have this functionality already in
> flight [1].
Yes, and it requires handling RTNL locks differently in several reset
and reconfig paths. Just adding netif_napi_set_*() won't work properly.
>
> Thanks,
> Tony
>
> [1] https://lore.kernel.org/intel-wired-lan/20250624164515.2663137-4-
> aleksander.lobakin@intel.com/
Thanks,
Olek
prev parent reply other threads:[~2025-07-18 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 21:12 Samiullah Khawaja
2025-07-17 20:25 ` Tony Nguyen
2025-07-18 13:06 ` Alexander Lobakin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b1b668e-19a0-4191-a5c7-686e05a08a80@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=anjali.singhai@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=skhawaja@google.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®