From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8794C43387 for ; Thu, 27 Dec 2018 08:15:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 892D320856 for ; Thu, 27 Dec 2018 08:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730399AbeL0IPL (ORCPT ); Thu, 27 Dec 2018 03:15:11 -0500 Received: from mga07.intel.com ([134.134.136.100]:53406 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728809AbeL0IPL (ORCPT ); Thu, 27 Dec 2018 03:15:11 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2018 00:15:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,404,1539673200"; d="scan'208";a="110243760" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.56]) ([10.237.72.56]) by fmsmga007.fm.intel.com with ESMTP; 27 Dec 2018 00:15:07 -0800 Subject: Re: [PATCH V5 1/3] mmc: sdhci: Fix sdhci_do_enable_v4_mode To: Sowjanya Komatineni , robh+dt@kernel.org, mark.rutland@arm.com, mperttunen@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, ulf.hansson@linaro.org Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org References: <1545355509-6914-1-git-send-email-skomatineni@nvidia.com> <1545355509-6914-2-git-send-email-skomatineni@nvidia.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <9b1f6ba3-113a-7c65-81af-fe911c51a875@intel.com> Date: Thu, 27 Dec 2018 10:13:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1545355509-6914-2-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/12/18 3:25 AM, Sowjanya Komatineni wrote: > V4_MODE is Bit-15 of SDHCI_HOST_CONTROL2 register. > Need to perform word access to this register. > > Signed-off-by: Sowjanya Komatineni This patch has already been applied. > --- > drivers/mmc/host/sdhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 99bdae53fa2e..fde984d10619 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -127,12 +127,12 @@ static void sdhci_do_enable_v4_mode(struct sdhci_host *host) > { > u16 ctrl2; > > - ctrl2 = sdhci_readb(host, SDHCI_HOST_CONTROL2); > + ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2); > if (ctrl2 & SDHCI_CTRL_V4_MODE) > return; > > ctrl2 |= SDHCI_CTRL_V4_MODE; > - sdhci_writeb(host, ctrl2, SDHCI_HOST_CONTROL); > + sdhci_writew(host, ctrl2, SDHCI_HOST_CONTROL2); > } > > /* >