From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF80CC48BCF for ; Sat, 12 Jun 2021 12:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC20461248 for ; Sat, 12 Jun 2021 12:25:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231229AbhFLM1a (ORCPT ); Sat, 12 Jun 2021 08:27:30 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:48857 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbhFLM10 (ORCPT ); Sat, 12 Jun 2021 08:27:26 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CAA4758069B; Sat, 12 Jun 2021 08:25:26 -0400 (EDT) Received: from imap21 ([10.202.2.71]) by compute3.internal (MEProxy); Sat, 12 Jun 2021 08:25:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm1; bh=3PQQZVdLA4n4rlbpJkJAKwEqsxv+ D18QX971oe6+lnc=; b=t+pToX6ylR7fe3vR3pb6OB46fkMMUWm198p/1XFQzlYa mU+LDEFNrDGHzC8HgfOJovx/IZMzSsW2LznbFn720KiIRwOjYDF7KXgb2R+MzM+K JW1mhC54J3eW5uNby5olGvI2/A2fheOx1iJlpgbdg5fQAUhk+ENbTs4CbEIQHLvN OLY02bhKIcOe202N++fBVeZpsjEhkb4mkW58w8yOOgHF1HPcUDZzladLEKexg4mt rmCkEVeJfJuz9J6DcIyfnUAkEXDDYJHEE5LrQ17fRED1ael9BQgr0WINMlQSb6Lc Ixc1ZSAjuSu2Rk9qhRJG2rPfcTqbMS0oJHmbM18Vcw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=3PQQZV dLA4n4rlbpJkJAKwEqsxv+D18QX971oe6+lnc=; b=Ny6N8vAlMSgGbeQFUTyrkq MPdVvNnienI+/h/kmb77s16Qrp++a1FnaC0wYyj6/Qafk6DZoa4mi3t0M4WbGfWF 1beaUtLPeEnXFWDIAuua5ZfLD059AZjIOR6FaEqUzTVzWh5P7X5d5DmqZt0ptlYz b2DQw+Jf3znqhM3qDbbI7HN8oRSSNhDbC0pZqM5DUF4v7hwotIE05ZYMXHxuiOuM +y7ygfyzaTFQDG5Ky4lPdvEVFiE/UD9PbzTbfv1k8Q+Uj53EE5VOf+PXFJvtAgbX b47qqrdl21EeTUsG5PqmbIngbpp2FgpQWNpoH/kpCsEb9yXCMv5sm9p+EHtmHXDw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvtddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdfuvhgv nhcurfgvthgvrhdfuceoshhvvghnsehsvhgvnhhpvghtvghrrdguvghvqeenucggtffrrg htthgvrhhnpefgieegieffuefhtedtjefgteejteefleefgfefgfdvvddtgffhffduhedv feekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsvhgvnhesshhvvghnphgvthgvrhdruggvvh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id BE28B51C0060; Sat, 12 Jun 2021 08:25:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-519-g27a961944e-fm-20210531.001-g27a96194 Mime-Version: 1.0 Message-Id: <9b226219-bf87-4fd4-8d99-9436861ca3cf@www.fastmail.com> In-Reply-To: <20210610165244.GA1948260@robh.at.kernel.org> References: <20210603085003.50465-1-sven@svenpeter.dev> <20210603085003.50465-3-sven@svenpeter.dev> <20210610165244.GA1948260@robh.at.kernel.org> Date: Sat, 12 Jun 2021 14:24:55 +0200 From: "Sven Peter" To: "Rob Herring" Cc: "Will Deacon" , "Robin Murphy" , "Joerg Roedel" , "Arnd Bergmann" , devicetree@vger.kernel.org, "Hector Martin" , linux-kernel@vger.kernel.org, "Marc Zyngier" , "Mohamed Mediouni" , "Stan Skowronek" , linux-arm-kernel@lists.infradead.org, "Mark Kettenis" , "Petr Mladek via iommu" , "Alexander Graf" Subject: Re: [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jun 10, 2021, at 18:52, Rob Herring wrote: > On Thu, Jun 03, 2021 at 10:50:02AM +0200, Sven Peter wrote: > > + > > +examples: > > + - |+ > > + dart1: iommu@82f80000 { > > + compatible = "apple,t8103-dart"; > > + reg = <0x82f80000 0x4000>; > > + interrupts = <1 781 4>; > > + #iommu-cells = <1>; > > + }; > > + > > + master1 { > > + iommus = <&{/dart1} 0>; > > /dart1 is a path, but 'dart1' is a label. You need '&dart1' (or > '&{/iommu@82f80000}' but that doesn't really work here because the > examples get prefixed with /example-n/...) > > With that fixed, > > Reviewed-by: Rob Herring Makes sense, thanks for the review! Fixed for the next version. Sven