mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: MoYuanhao <moyuanhao3676@163.com>
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
	linux-kernel@vger.kernel.org, martineau@kernel.org,
	geliang@kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org
Subject: Re: [PATCH] mptcp: remove the redundant assignment of 'new_ctx->tcp_sock' in subflow_ulp_clone()
Date: Wed, 6 Nov 2024 16:41:10 +0100	[thread overview]
Message-ID: <9b265c9b-f101-4ea3-83b6-7709e8f2ea47@kernel.org> (raw)
In-Reply-To: <20241106071035.2591-1-moyuanhao3676@163.com>

Hi MoYuanhao, Netdev maintainers,

On 06/11/2024 08:10, MoYuanhao wrote:
> The variable has already been assigned in the subflow_create_ctx(),
> So we don't need to reassign this variable in the subflow_ulp_clone().

Good catch, no need to reassign it there.

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>


I guess this patch is for net-next. Please next time clearly indicate
for which tree this patch is for, by adding this in the patch prefix:

  [PATCH net-next]

See: https://docs.kernel.org/process/maintainer-netdev.html

Also, please try to keep the patch title under ~50 chars.


@Netdev maintainers: is it OK for you to apply this small patch in
net-next directly?


Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2024-11-06 15:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06  7:10 MoYuanhao
2024-11-06 15:41 ` Matthieu Baerts [this message]
2024-11-07  1:18   ` Jakub Kicinski
2024-11-09 17:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b265c9b-f101-4ea3-83b6-7709e8f2ea47@kernel.org \
    --to=matttbe@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geliang@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=moyuanhao3676@163.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®