From: zhenggy <zhenggy@chinatelecom.cn>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] sched: Fix rq nr_uninterruptible count
Date: Tue, 28 Feb 2023 15:08:58 +0800 [thread overview]
Message-ID: <9b271641-ea59-daa5-333c-1dd1f02cdb52@chinatelecom.cn> (raw)
When an uninterrptable task is queue to a differect cpu as where
it is dequeued, the rq nr_uninterruptible will be incorrent, so
fix it.
Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
---
kernel/sched/core.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 25b582b..cd5ef6e 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4068,6 +4068,7 @@ bool ttwu_state_match(struct task_struct *p, unsigned int state, int *success)
{
unsigned long flags;
int cpu, success = 0;
+ struct rq *src_rq, *dst_rq;
preempt_disable();
if (p == current) {
@@ -4205,6 +4206,16 @@ bool ttwu_state_match(struct task_struct *p, unsigned int state, int *success)
atomic_dec(&task_rq(p)->nr_iowait);
}
+ if (p->sched_contributes_to_load) {
+ src_rq = cpu_rq(task_cpu(p));
+ dst_rq = cpu_rq(cpu);
+
+ double_rq_lock(src_rq, dst_rq);
+ src_rq->nr_uninterruptible--;
+ dst_rq->nr_uninterruptible++;
+ double_rq_unlock(src_rq, dst_rq);
+ }
+
wake_flags |= WF_MIGRATED;
psi_ttwu_dequeue(p);
set_task_cpu(p, cpu);
--
1.8.3.1
next reply other threads:[~2023-02-28 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 7:08 zhenggy [this message]
2023-02-28 8:13 ` Slade's Kernel Patch Bot
2023-02-28 8:56 ` Bagas Sanjaya
2023-02-28 9:27 ` Mike Galbraith
2023-02-28 8:46 zhenggy
2023-02-28 9:38 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b271641-ea59-daa5-333c-1dd1f02cdb52@chinatelecom.cn \
--to=zhenggy@chinatelecom.cn \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®