mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Jenkins <sourcejedi.lkml@googlemail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Mario Limonciello <mario_limonciello@dell.com>,
	cezary.jackiewicz@gmail.com, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Add rfkill support to compal-laptop
Date: Tue, 18 Aug 2009 09:33:03 +0100	[thread overview]
Message-ID: <9b2b86520908180133r3f5ddd7ev8a345832f2785abc@mail.gmail.com> (raw)
In-Reply-To: <1250558643.30166.109.camel@localhost.localdomain>

On 8/18/09, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Mario,

...

>> +static void compal_rfkill_query(struct rfkill *rfkill, void *data)
>> +{
>> +       unsigned long radio = (unsigned long) data;
>> +       u8 result;
>> +       bool blocked;
>> +
>> +       ec_read(COMPAL_EC_COMMAND_WIRELESS, &result);
>> +
>> +       if ((result & KILLSWITCH_MASK) == 0)
>> +               blocked = 1;
>> +        else if (radio == WLAN_MASK)
>> +               blocked = !(result & WLAN_MASK);
>
> You are using spaces instead of tabs here.

Btw Mario, scripts/checkpatch.pl is a good way to check for whitespace
errors and a bunch of other trivia.  So human patch review can
concentrate on the important stuff :-).

Thanks
Alan

  parent reply	other threads:[~2009-08-18  8:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 23:27 Mario Limonciello
2009-08-18  1:24 ` Marcel Holtmann
2009-08-18  7:44   ` Alan Jenkins
2009-08-18 14:52     ` Alan Jenkins
2009-08-18 17:26       ` Mario Limonciello
2009-08-18 21:08         ` Alan Jenkins
2009-08-18 21:31           ` Johannes Berg
2009-08-18 22:00             ` Mario Limonciello
2009-08-19  8:51               ` Alan Jenkins
2009-08-19  9:01               ` Johannes Berg
2009-08-19 11:43                 ` Cezary Jackiewicz
2009-08-19 16:46                 ` Mario Limonciello
2009-08-19 16:57                   ` Alan Jenkins
2009-08-19 17:13                   ` Johannes Berg
2009-08-19 18:39                     ` Mario Limonciello
2009-08-18 21:17         ` Alan Jenkins
2009-08-18  8:33   ` Alan Jenkins [this message]
2009-08-18  8:19 ` Alan Jenkins
2009-08-18 12:22   ` Alan Jenkins
2009-08-19 18:36 Mario Limonciello
2009-08-19 18:42 ` Johannes Berg
2009-08-19 18:47   ` Mario Limonciello
2009-08-20  8:52     ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b2b86520908180133r3f5ddd7ev8a345832f2785abc@mail.gmail.com \
    --to=sourcejedi.lkml@googlemail.com \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mario_limonciello@dell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®