From: Alan Jenkins <sourcejedi.lkml@googlemail.com>
To: Dan Carpenter <error27@gmail.com>, linux-kernel@vger.kernel.org
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [patch] hp-wmi: fix double free
Date: Sun, 10 Jan 2010 10:38:37 +0000 [thread overview]
Message-ID: <9b2b86521001100238x5c373f7x856a255e940baa5d@mail.gmail.com> (raw)
In-Reply-To: <20100110074529.GF7840@bicker>
On 1/10/10, Dan Carpenter <error27@gmail.com> wrote:
> kfree(obj) was called earlier.
>
> This was found by smatch and has only been compile tested. :/
I don't see hp-wmi in MAINTAINERS, but in general platform drivers go
via the ACPI tree.
It looks like several others have discovered this issue the hard way
:-). <http://www.pubbs.net/kernel/201001/14288/>.
Fortunately it has been fixed in the acpi tree and now submitted to
Linus. <http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-01/msg02511.html>.
Regards
Alan
> --- orig/drivers/platform/x86/hp-wmi.c 2010-01-09 21:43:13.000000000 +0300
> +++ devel/drivers/platform/x86/hp-wmi.c 2010-01-09 21:43:28.000000000 +0300
> @@ -388,8 +388,6 @@ static void hp_wmi_notify(u32 value, voi
> } else
> printk(KERN_INFO "HP WMI: Unknown key pressed - %x\n",
> eventcode);
> -
> - kfree(obj);
> }
prev parent reply other threads:[~2010-01-10 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 7:45 Dan Carpenter
2010-01-10 10:38 ` Alan Jenkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b2b86521001100238x5c373f7x856a255e940baa5d@mail.gmail.com \
--to=sourcejedi.lkml@googlemail.com \
--cc=error27@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®