From: Alan Jenkins <sourcejedi.lkml@googlemail.com>
To: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Alexey Starikovskiy <astarikovskiy@suse.de>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Maxim Levitsky <maximlevitsky@gmail.com>
Subject: Re: [Resend][PATCH] ACPI / EC: Remove race between EC driver and suspend process (rev. 3)
Date: Thu, 4 Mar 2010 09:32:03 +0000 [thread overview]
Message-ID: <9b2b86521003040132v168399ct9241f3ad9ff8c4c7@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1003040047310.1741@localhost.localdomain>
On 3/4/10, Len Brown <lenb@kernel.org> wrote:
> Isn't the problem at hand that the boot-kernel stops
> in mid-transaction, and the resumed hibernate image
> then blunders forward with its first transaction
> only to find the EC in an intermediate state?
>
> If yes, I then making the transaction atomic WRT
> the boot kernel stopping should fix the problem.
>
> The patch sets a FROZEN bit, and subsequent
> requests for EC transactions simply fail.
> How do we know that we set the bit at the right time?
> What transactions or parts of transactions will fail,
> and what are the consequences of those failures?
The problem transactions on my machine were probably started by
ec_check_sci(). I.e. QUERY transactions which read the value of an
event raised by the EC. (I triggered the problem by pressing ACPI
hotkeys, although I haven't been able to reproduce it since).
That might explain why the transactions can be asynchronous with the
s2disk task - because these transactions are run in the ACPI
workqueue. Perhaps the workqueue needs to be flushed after the EC GPE
is disabled?
Alan
next prev parent reply other threads:[~2010-03-04 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 20:40 Rafael J. Wysocki
2010-03-03 21:49 ` Len Brown
2010-03-04 0:52 ` Rafael J. Wysocki
2010-03-04 5:55 ` Len Brown
2010-03-04 9:32 ` Alan Jenkins [this message]
2010-03-04 19:20 ` Rafael J. Wysocki
2010-03-08 21:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b2b86521003040132v168399ct9241f3ad9ff8c4c7@mail.gmail.com \
--to=sourcejedi.lkml@googlemail.com \
--cc=astarikovskiy@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=maximlevitsky@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®