From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6D1729BD87 for ; Mon, 16 Mar 2026 12:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773663528; cv=none; b=th0DvbR10X6nVIXG7G7dfyAWrA2bvn+OnIX+wdQxGYqMGIV0fqshL8SuKaLndUF43TozpSs6oCA0fyk+sVQN+lb+cIxhAh4zwy7iGgRs7/hDv34XCLKSQ+sz2vmiUQvjFhxb0hsoN6UDlRP8S3zAa1J15Ric84pEi7ralwrIYFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773663528; c=relaxed/simple; bh=Q82HE3TEiHi8Op6bSnZtYZsDTlb4Qos/35Qqzi9VeAc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=OdZnBF/qHbTcHlA2WdAHKdawP5qXijY1YcjqO8STiiaoIL2eyqSUuD5fCQ1BJOAR0vly33vmWfYr6NUTt6D4D92jsEaL5e+YwyC180G9Bx659jWRcArPthOrFVguLYI6GOgaxg1PkCW5OB/CmiTzmSTBXr4eAST8KaJejyqsO1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=YMbihowt; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=g/RQt8/Z; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=YMbihowt; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=g/RQt8/Z; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="YMbihowt"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="g/RQt8/Z"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="YMbihowt"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="g/RQt8/Z" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DC46F5BD1A; Mon, 16 Mar 2026 12:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773663524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mB9Tj05DF4lv5T+QxlQXo7H+zML20YMLhiJtCrtfPgA=; b=YMbihowtfo2GjiPz4aQmTrHixBFJuyIjMLqNHhsnSvrrdDJ0D5vtThpK/yJ10whM+FbnY1 HAHJF40UoFuuE5nEvpWV6ZIyU4S4IUF41cObxCLBHCBglZG/a1hGvrO51UrAMhZU7mk9wi VID50r/T/huXYCy1Hib/TxbEVvrpx9U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773663524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mB9Tj05DF4lv5T+QxlQXo7H+zML20YMLhiJtCrtfPgA=; b=g/RQt8/ZJPi7TiVJ91ZFWYt4v0Yxn2FFupdXKQm44etrzj5XjgthDIDoLpuKeNr+xbkGHP qFFWC4hIG7IrKsAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YMbihowt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="g/RQt8/Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773663524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mB9Tj05DF4lv5T+QxlQXo7H+zML20YMLhiJtCrtfPgA=; b=YMbihowtfo2GjiPz4aQmTrHixBFJuyIjMLqNHhsnSvrrdDJ0D5vtThpK/yJ10whM+FbnY1 HAHJF40UoFuuE5nEvpWV6ZIyU4S4IUF41cObxCLBHCBglZG/a1hGvrO51UrAMhZU7mk9wi VID50r/T/huXYCy1Hib/TxbEVvrpx9U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773663524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mB9Tj05DF4lv5T+QxlQXo7H+zML20YMLhiJtCrtfPgA=; b=g/RQt8/ZJPi7TiVJ91ZFWYt4v0Yxn2FFupdXKQm44etrzj5XjgthDIDoLpuKeNr+xbkGHP qFFWC4hIG7IrKsAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 720114273B; Mon, 16 Mar 2026 12:18:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8palGiT1t2k8VAAAD6G6ig (envelope-from ); Mon, 16 Mar 2026 12:18:44 +0000 Message-ID: <9b3354fe-ff49-4436-9f36-2a19eaf2918c@suse.de> Date: Mon, 16 Mar 2026 13:18:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/i915/fbdev: fix link failure without FBDEV emulation From: Thomas Zimmermann To: Arnd Bergmann , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Uma Shankar , Mika Kahola , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Vinod Govindapillai Cc: Arnd Bergmann , =?UTF-8?Q?Jouni_H=C3=B6gander?= , Chaitanya Kumar Borah , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260304083701.724908-1-arnd@kernel.org> Content-Language: en-US Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[17]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[kernel.org,linux.intel.com,intel.com,ursulin.net,gmail.com,ffwll.ch]; URIBL_BLOCKED(0.00)[suse.com:url,arndb.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ASN(0.00)[asn:32098, ipnet:2800::/6, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.com:url] X-Rspamd-Queue-Id: DC46F5BD1A X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: Hi Am 04.03.26 um 09:43 schrieb Thomas Zimmermann: > Hi > > Am 04.03.26 um 09:36 schrieb Arnd Bergmann: >> From: Arnd Bergmann >> >> If CONFIG_DRM_FBDEV_EMULATION is disabled but CONFIG_FRAMEBUFFER_CONSOLE >> is turned on, the i915 driver now fails to link: >> >> ERROR: modpost: "intel_fbdev_fb_prefer_stolen" >> [drivers/gpu/drm/i915/i915.ko] undefined! >> >> Fix the contition to include a check for the symbol that controls >> compilation >> of intel_fbdev_fb.c. >> >> Fixes: 94c7d2861292 ("drm/i915/fbdev: Extract >> intel_fbdev_fb_prefer_stolen()") >> Signed-off-by: Arnd Bergmann >> --- >>   drivers/gpu/drm/i915/i915_initial_plane.c | 3 ++- >>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_initial_plane.c >> b/drivers/gpu/drm/i915/i915_initial_plane.c >> index 5594548f51d8..390a9248d631 100644 >> --- a/drivers/gpu/drm/i915/i915_initial_plane.c >> +++ b/drivers/gpu/drm/i915/i915_initial_plane.c >> @@ -115,7 +115,8 @@ initial_plane_vma(struct drm_i915_private *i915, >>        * important and we should probably use that space with FBC or >> other >>        * features. >>        */ >> -    if (IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) && >> +    if (IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION) && >> +        IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) && > > It's possible to run fbdev without the console. So if I'm not > mistaken, only CONFIG_DRM_FBDEV_EMULATION would be correct. Did anyone pick up this fix? Best regards Thomas > > Best regards > Thomas > > >>           mem == i915->mm.stolen_region && >>           !intel_fbdev_fb_prefer_stolen(&i915->drm, size)) { >>           drm_dbg_kms(&i915->drm, "Initial FB size exceeds half of >> stolen, discarding\n"); > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)