From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A6CC433EF for ; Fri, 15 Jul 2022 17:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229969AbiGORd0 (ORCPT ); Fri, 15 Jul 2022 13:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbiGORdW (ORCPT ); Fri, 15 Jul 2022 13:33:22 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC4484ED4 for ; Fri, 15 Jul 2022 10:33:21 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id bu1so7630614wrb.9 for ; Fri, 15 Jul 2022 10:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=r/j/m+wyr307kXy5lDQqkPdMiEPAS3CHEBDizNY4AHg=; b=hF39XAP/v2azVgo6MzG6JSpJCFT2cNv3ocE0sQhzJ6wi5bTN2YWutgSYJRo1r6+ihw TCrrPAMy0ldc2yta6wuzwuQL9koG8Xyz/MDauuQvlITNLfk5czZTMpR3w2RAHrJe0OZJ tQC9nO7BwIX/eRzKSap1/0MbStIP2cxCiqXIRImn2sCOCY2hmFbLZ9lNjkMfTvN8mGwC ErlAhEy2Cg2pYMEYQF0R3bM97H93L7QpP0bTcIhaMnMYTSwWKrnIq6aiIr4smINbxUSZ eeLbjseeIxg5wQfLOCfD57arQihWp/WCU8AyOhSR2HZlyHlJ8uUMZgWOfNdK9SokpPHu 2REg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=r/j/m+wyr307kXy5lDQqkPdMiEPAS3CHEBDizNY4AHg=; b=kuc7AfhXDyVwcUQKLo8lcRlSdb3WfnWV4wYRTMQRN3RYvqkleRbFDG5qcxWLYdsOG0 c9XQcfQKmUlDUOMefQH9t0pf1Rb5zRtudM48931IQv333+cc8VghI5IpAhDAeMd5NYyX s3tNhTZkVX7rP0wC6XzkOAYf3DiSIgLOaXksnR0BfLRu9U7ytuskpLGE3rFSOFa1fQPS i4xsCccLsRkj4phR2m9pQGy5laYAeo+kYzVVduLrK7cNHG7n5rCfslyD7Qc4qAdnuC4s 4CJ+RY6EQpn3vzmruqqZAMJbClbJ1Vq3eq7LTahKBzuFyWIV9gA2O1Sua4LT+d0VKS0m u56g== X-Gm-Message-State: AJIora8PFUMnUbWAWMjrOgGThg3tAExR9vnbg1W3tQMskjModuFTnWEB mqBUUmUS67JwtQasUJjC/CI24w== X-Google-Smtp-Source: AGRyM1tcFyG5FnrA5P4VLrG8T8mmfCFyZQh3fzCp4bSeGshwogoDUfjmIcAU8JcmIOxcGpClhVr/5A== X-Received: by 2002:a5d:4c91:0:b0:21d:8293:66dc with SMTP id z17-20020a5d4c91000000b0021d829366dcmr14512376wrs.30.1657906400259; Fri, 15 Jul 2022 10:33:20 -0700 (PDT) Received: from [10.35.4.171] ([167.98.27.226]) by smtp.gmail.com with ESMTPSA id y16-20020adfe6d0000000b00213ba3384aesm4260976wrm.35.2022.07.15.10.33.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 10:33:19 -0700 (PDT) Message-ID: <9b37e02f-137f-2f93-43b9-eb5bb9814e97@sifive.com> Date: Fri, 15 Jul 2022 18:33:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] net: macb: fixup sparse warnings on __be16 ports Content-Language: en-GB To: Jakub Kicinski Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee , Jude Onyenegecha , Nicolas Ferre , Claudiu Beznea , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org References: <20220714084305.209425-1-ben.dooks@sifive.com> <20220714164336.0f2768a2@kernel.org> From: Ben Dooks In-Reply-To: <20220714164336.0f2768a2@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/07/2022 00:43, Jakub Kicinski wrote: > On Thu, 14 Jul 2022 09:43:05 +0100 Ben Dooks wrote: >> - htons(fs->h_u.tcp_ip4_spec.psrc), htons(fs->h_u.tcp_ip4_spec.pdst)); >> + be16_to_cpu(fs->h_u.tcp_ip4_spec.psrc), >> + be16_to_cpu(fs->h_u.tcp_ip4_spec.pdst)); > > There are some spaces on this line, please use tabs, > checkpatch will be able to help you validate. Thank you, didn't spot an issue with my editor config. Sent v2 patch