mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Paul Sajna <sajattack@postmarketos.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	David Heidelberg <david@ixit.cz>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Amir Dahan <system64fumo@tuta.io>,
	Christopher Brown <crispybrown@gmail.com>
Subject: Re: [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb
Date: Fri, 5 Dec 2025 11:35:10 +0100	[thread overview]
Message-ID: <9b3f2adc-bd64-4f6f-8a40-9e2884e46782@oss.qualcomm.com> (raw)
In-Reply-To: <7909626f3116fcb9feb25b77820a98da56e1283a@postmarketos.org>

On 12/4/25 7:47 PM, Paul Sajna wrote:
> December 4, 2025 at 12:50 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> 
> 
>>
>> On 12/3/25 10:40 AM, Paul Sajna wrote:
>>
>>>
>>> These regulators are required for the LCD
>>>  
>>>  Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>>>  ---
>>>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
>>>  1 file changed, 17 insertions(+)
>>>  
>>>  diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>>  index 8b88f75b36af..cdaf84de5e6c 100644
>>>  --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>>  +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>>  @@ -56,10 +56,27 @@ zap-shader {
>>>  };
>>>  };
>>>  
>>>  +&ibb {
>>>  + regulator-min-microvolt = <5500000>;
>>>  + regulator-max-microvolt = <5700000>;
>>>
>> These ranges seem much more reasonable, although I would still
>> expect there's a single operational voltage - unless the panel driver
>> is supposed to call regulator_set_voltage() in some different power
>> modes?
>>
>> Konrad
>>
> 
> So min/max both 55? Or is there another property I should use?
> I wasn't sure if that would be physically hard for the regulator to maintain such precision, so I cross-referenced some other DTs in the qcom folder and found this 200mv allowance in one of the sony devices.

These regulators are very accurate - set it to 5.5

Konrad

  reply	other threads:[~2025-12-05 10:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-03  9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
2025-12-03  9:40 ` [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties Paul Sajna
2025-12-04 13:11   ` Krzysztof Kozlowski
2025-12-04 13:27     ` Konrad Dybcio
2025-12-06 21:40   ` David Heidelberg
2025-12-03  9:40 ` [PATCH v5 02/12] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
2025-12-03 13:44   ` David Heidelberg
2025-12-03  9:40 ` [PATCH v5 03/12] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger Paul Sajna
2025-12-03  9:40 ` [PATCH v5 04/12] arm64: dts: qcom: sdm845-lg-common: Add LEDs Paul Sajna
2025-12-03  9:40 ` [PATCH v5 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
2025-12-06  2:09   ` Dmitry Baryshkov
2025-12-06 12:37     ` David Heidelberg
2025-12-06 17:53       ` David Heidelberg
2025-12-03  9:40 ` [PATCH v5 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path Paul Sajna
2025-12-03 13:47   ` David Heidelberg
2025-12-06  2:11   ` Dmitry Baryshkov
2025-12-03  9:40 ` [PATCH v5 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node Paul Sajna
2025-12-06  2:12   ` Dmitry Baryshkov
2026-03-24  3:07     ` Paul Sajna
2025-12-03  9:40 ` [PATCH v5 08/12] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
2025-12-03  9:40 ` [PATCH v5 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
2025-12-03  9:40 ` [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb Paul Sajna
2025-12-04 12:50   ` Konrad Dybcio
2025-12-04 18:47     ` Paul Sajna
2025-12-05 10:35       ` Konrad Dybcio [this message]
2025-12-03  9:41 ` [PATCH v5 11/12] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self' Paul Sajna
2025-12-04  9:22   ` Konrad Dybcio
2025-12-03  9:41 ` [PATCH v5 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem Paul Sajna
2025-12-04  9:23   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b3f2adc-bd64-4f6f-8a40-9e2884e46782@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=crispybrown@gmail.com \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sajattack@postmarketos.org \
    --cc=system64fumo@tuta.io \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®