From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55C2423F40C for ; Tue, 5 Aug 2025 12:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754395678; cv=none; b=GCHwgfyuk4J6ryjTAk9suerMgZLdvR9XABcAO3VRlcNXcZipIJWqjJCt4g9IlSYxke+Wlmr0YJuOAd+U0ONPIyFhRZZXOZGzhD5e8cSMUNstN5ZsxCr+AJT0ZBK8uvqOA8ZhkKjJhhlReFUAtL340VYIPQK+kkwi95/cSC+Wqc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754395678; c=relaxed/simple; bh=IppRhA9f5LX9Nb32MXQBE5CFGdG98rfIOP9iCkcxLn8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KNTtoLsqJJF4xAcQqvNIXbRpD9EK8dfoz8HB6vFPWliJtEIFOfZjVlkb5pM8OMvtKBm+IkBOeS/tncnmaVtKVy1zVBioHcqMzU9IxgQ8bW1NQ5NLLB0n4vm/9W6f94/I0DV7Dj17lAY2ysk43hD7cGEdvokzOKuMRD92muvo9HM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hvPkNgNb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hvPkNgNb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754395674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7g5TY6RCcpzFCYXDHvD8PiehF1IggpjyaG88FCPGaI8=; b=hvPkNgNbS111p1Yk0wPs9yvlc7t8096txUrsqi7Jg/7esywAqnetKJws6lwyh+fJmVINEH wsjO8liFBBV4zaCZrBtVn1Mt615PJRUNx+sGWwYPCSvyNapDjEyx+HfKLKt5P9UU41BwBh Gd5XQMkdIWCACtkV7H2eh3577JjGtoU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-UFct9GWjM9KkRkOnCpePiQ-1; Tue, 05 Aug 2025 08:07:53 -0400 X-MC-Unique: UFct9GWjM9KkRkOnCpePiQ-1 X-Mimecast-MFC-AGG-ID: UFct9GWjM9KkRkOnCpePiQ_1754395672 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-458a31421a3so20484415e9.0 for ; Tue, 05 Aug 2025 05:07:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754395672; x=1755000472; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7g5TY6RCcpzFCYXDHvD8PiehF1IggpjyaG88FCPGaI8=; b=Ug5crU/kQZLKFs12mt3UzeH2xITeDrG09bxgn4uOtTyFckVO/3VHhYd2wQZmqXfOXj kVA1l40MjpMvU5ejr0URZmsfQePule1cNL34QGrpYI2nIlTcAkr6HXD8lEEg7BgsZEju yGvk2RcL5W2JhQGh+pD3VVv6LsVDgyk7WDlo5Gv7adlBU2F8XwMhJ++NmiPSw5xZVSk2 qSxWXylLVDL/hhCFKFS4HIvX2Wmh10ErTFfsA3eKddbPbm3u1tWiV+G5bQz/Mq2IpyV1 LUj6HeuHNa2Rts/VZ2sBuLW4ttJtRDGvHofolPkNxBV0+W2z4qjJbuqZsqVQ0iJ2r9jF IeBg== X-Forwarded-Encrypted: i=1; AJvYcCVKCZ7GfbSf/LXFYDmFAtJ4213oF9KYLf6XSGWhoo3N22xwVe6mTE0DlvJdfLq+5Cpno1zIRj6QedcJ/GE=@vger.kernel.org X-Gm-Message-State: AOJu0YzCqfWebRflLhMq5x0XLzTWunv0O+lgdayT2s1AU/E9n4Wt3bvG b1/YeKhDQJ7sqzFO0QR7AdOMigg7KehDhbP/JHIOAd4JrqNDFUA4pHsPROo3rC5Hi4IzAOtruaQ 4pzvJ4vc8UVEQTdDLgp4bCgxPG6bva2FzdITc83U57fMwMXdrOM4xMPYk10lnJY9x4A== X-Gm-Gg: ASbGncsgb5P/9FYF0luTRMawY1jBIbQPYe5uxEfd1nDVpreQCZf7RTnQueASXGWLF6r 6WfO5y0NvU76lyJdWydjf5NvRLP/ufAyyMoCRlJysxuu+j9UxCyZY1qTa73LMLT8oCRs5wWBzDj 0R9dsoZd769BA7S2Wul5Iroo/F1cXqOV9QZiW+f6LK5INvKwu+6iUvEHSY8jC2maa6yyHh9nb3N BPGeOqW0U3vWNPX8gS5rXl1e3xUhJiBluFWFQORf9elJVAas1ab2PNfJMjs4/RJe2yoZYhuqcH4 ppB2ZuNVNTfhGAbLMCRh9n1Kx+AGZFFYp8W2owWIYi9SVpiXQFFfwR124ApGhXLO8g+t+2qATX/ 0dWCEBaVTELbxTa+erPls0PWXpD7ICpA3C4PSlkhNWJYW5DHp/z/JU06RCS1WCUXl3G8= X-Received: by 2002:a05:600c:a43:b0:456:173c:8a53 with SMTP id 5b1f17b1804b1-458b69c8300mr110640375e9.2.1754395671745; Tue, 05 Aug 2025 05:07:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+IhNRqRL6jSPu1sN+HeHznfpj9c1/PPhayfhWO2xWYBfi+odz5/vWfgQK82w4OMctODG6Xg== X-Received: by 2002:a05:600c:a43:b0:456:173c:8a53 with SMTP id 5b1f17b1804b1-458b69c8300mr110640065e9.2.1754395671242; Tue, 05 Aug 2025 05:07:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2b:b200:607d:d3d2:3271:1be0? (p200300d82f2bb200607dd3d232711be0.dip0.t-ipconnect.de. [2003:d8:2f2b:b200:607d:d3d2:3271:1be0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459de0d4cf1sm59347605e9.13.2025.08.05.05.07.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 05:07:50 -0700 (PDT) Message-ID: <9b447a66-7dcb-442b-9d45-f0b14688aa8c@redhat.com> Date: Tue, 5 Aug 2025 14:07:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] VFIO updates for v6.17-rc1 To: Jason Gunthorpe Cc: Alex Williamson , Linus Torvalds , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lizhe.67@bytedance.com" References: <20250804162201.66d196ad.alex.williamson@redhat.com> <20250804185306.6b048e7c.alex.williamson@redhat.com> <0a2e8593-47c6-4a17-b7b0-d4cb718b8f88@redhat.com> <20250805114908.GE184255@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250805114908.GE184255@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.08.25 13:49, Jason Gunthorpe wrote: > On Tue, Aug 05, 2025 at 09:47:18AM +0200, David Hildenbrand wrote: >>> There was discussion here[1] where David Hildenbrand and Jason >>> Gunthorpe suggested this should be in common code and I believe there >>> was some intent that this would get reused. I took this as >>> endorsement from mm folks. This can certainly be pulled back into >>> subsystem code. >> >> Yeah, we ended up here after trying to go the folio-way first, but then >> realizing that code that called GUP shouldn't have to worry about >> folios, just to detect consecutive pages+PFNs. >> >> I think this helper will can come in handy even in folio context. >> I recall pointing Joanne at it in different fuse context. > > The scatterlist code should use it also, it is doing the same logic. > >> The concern is rather false positives, meaning, you want consecutive >> PFNs (just like within a folio), but -- because the stars aligned -- >> you get consecutive "struct page" that do not translate to consecutive PFNs. > > I wonder if we can address that from the other side and prevent the > memory code from creating a bogus contiguous struct page in the first > place so that struct page contiguity directly reflects physical > contiguity? Well, if we could make CONFIG_SPARSEMEM_VMEMMAP the only sparsemem option ... :) But I recall it's not that easy (e.g., 32bit). I don't see an easy way to guarantee that. E.g., populate_section_memmap really just does a kvmalloc_node() and __populate_section_memmap()->memmap_alloc() a memblock_alloc(). So if the starts align, the "struct page" of the memory of two memory sections are contiguous, although the memory sections are not contiguous. Just imagine memory holes. Also, I am not sure if that is really a problem worth solving right now. If a helper on !CONFIG_SPARSEMEM_VMEMMAP is a little slower on some operations, like nth_page(), I really don't particularly care. Eventually, !CONFIG_SPARSEMEM_VMEMMAP will go away in some distant future and we will all be happy. -- Cheers, David / dhildenb