From: Andrew Lunn <andrew@lunn.ch>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shenjian15@huawei.com, liuyonglong@huawei.com,
chenhao418@huawei.com, jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 net-next 1/3] net: hibmcge: support scenario without PHY
Date: Wed, 2 Jul 2025 00:07:08 +0200 [thread overview]
Message-ID: <9b45bab6-dc6e-40b5-b37c-2b296213e8ed@lunn.ch> (raw)
In-Reply-To: <20250701125446.720176-2-shaojijie@huawei.com>
> + phydev = fixed_phy_register(&hbg_fixed_phy_status, NULL);
> + if (IS_ERR(phydev)) {
> + dev_err_probe(dev, IS_ERR(phydev),
IS_ERR() returns a bool, where as dev_err_probe() expects an int.
> + "failed to register fixed PHY device\n");
> + return IS_ERR(phydev);
This also looks wrong.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-07-01 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 12:54 [PATCH v4 net-next 0/3] Support some features for the HIBMCGE driver Jijie Shao
2025-07-01 12:54 ` [PATCH v4 net-next 1/3] net: hibmcge: support scenario without PHY Jijie Shao
2025-07-01 22:07 ` Andrew Lunn [this message]
2025-07-02 1:04 ` Jijie Shao
2025-07-01 12:54 ` [PATCH v4 net-next 2/3] net: hibmcge: adjust the burst len configuration of the MAC controller to improve TX performance Jijie Shao
2025-07-01 12:54 ` [PATCH v4 net-next 3/3] net: hibmcge: configure FIFO thresholds according to the MAC controller documentation Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b45bab6-dc6e-40b5-b37c-2b296213e8ed@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®