From: Arseniy Krasnov <avkrasnov@salutedevices.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>,
<kvm@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@sberdevices.ru>, <oxffffaa@gmail.com>
Subject: Re: [PATCH net-next v1 00/12] vsock/virtio: continue MSG_ZEROCOPY support
Date: Tue, 26 Sep 2023 22:40:04 +0300 [thread overview]
Message-ID: <9b467359-4e4d-619f-e71c-172f5614c4b2@salutedevices.com> (raw)
In-Reply-To: <zurqqucjbdnyxub6u7ya5gzt2nxgrgp4ggvz76smljqzfi6qzb@lr6ojra35bab>
On 26.09.2023 16:10, Stefano Garzarella wrote:
> Hi Arseniy,
>
> On Fri, Sep 22, 2023 at 08:24:16AM +0300, Arseniy Krasnov wrote:
>> Hello,
>>
>> this patchset contains second and third parts of another big patchset
>> for MSG_ZEROCOPY flag support:
>> https://lore.kernel.org/netdev/20230701063947.3422088-1-AVKrasnov@sberdevices.ru/
>>
>> During review of this series, Stefano Garzarella <sgarzare@redhat.com>
>> suggested to split it for three parts to simplify review and merging:
>>
>> 1) virtio and vhost updates (for fragged skbs) (merged to net-next, see
>> link below)
>> 2) AF_VSOCK updates (allows to enable MSG_ZEROCOPY mode and read
>> tx completions) and update for Documentation/. <-- this patchset
>> 3) Updates for tests and utils. <-- this patchset
>>
>> Part 1) was merged:
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=71b263e79370348349553ecdf46f4a69eb436dc7
>>
>> Head for this patchset is:
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=71b263e79370348349553ecdf46f4a69eb436dc7
>
> Thanks for the series.
> I did a quick review highlighting some things that need to be changed.
>
> Overall, the series seems to be in good shape. The tests went well.
>
> In the next few days I'll see if I can get a better look at the larger patches like the tests, or I'll check in the next version.
Hello Stefano,
Thanks for review, almost all comments are clear to me, I'll fix them.
Thanks, Arseniy
>
> Thanks,
> Stefano
>
prev parent reply other threads:[~2023-09-26 19:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 5:24 Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 01/12] vsock: fix EPOLLERR set on non-empty error queue Arseniy Krasnov
2023-09-26 12:54 ` Stefano Garzarella
2023-09-22 5:24 ` [PATCH net-next v1 02/12] vsock: read from socket's " Arseniy Krasnov
2023-09-26 12:55 ` Stefano Garzarella
2023-09-26 19:36 ` Arseniy Krasnov
2023-09-27 7:34 ` Stefano Garzarella
2023-09-27 7:34 ` Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 03/12] vsock: check for MSG_ZEROCOPY support on send Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 04/12] vsock: enable SOCK_SUPPORT_ZC bit Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 05/12] vhost/vsock: support MSG_ZEROCOPY for transport Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 06/12] vsock/virtio: " Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 07/12] vsock/loopback: " Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 08/12] vsock: enable setting SO_ZEROCOPY Arseniy Krasnov
2023-09-26 12:56 ` Stefano Garzarella
2023-09-26 19:38 ` Arseniy Krasnov
2023-09-27 7:35 ` Stefano Garzarella
2023-09-22 5:24 ` [PATCH net-next v1 09/12] docs: net: description of MSG_ZEROCOPY for AF_VSOCK Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 10/12] test/vsock: MSG_ZEROCOPY flag tests Arseniy Krasnov
2023-09-26 12:56 ` Stefano Garzarella
2023-09-22 5:24 ` [PATCH net-next v1 11/12] test/vsock: MSG_ZEROCOPY support for vsock_perf Arseniy Krasnov
2023-09-22 5:24 ` [PATCH net-next v1 12/12] test/vsock: io_uring rx/tx tests Arseniy Krasnov
2023-09-26 13:04 ` Stefano Garzarella
2023-09-26 20:00 ` Arseniy Krasnov
2023-09-27 7:37 ` Stefano Garzarella
2023-09-26 13:10 ` [PATCH net-next v1 00/12] vsock/virtio: continue MSG_ZEROCOPY support Stefano Garzarella
2023-09-26 19:40 ` Arseniy Krasnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b467359-4e4d-619f-e71c-172f5614c4b2@salutedevices.com \
--to=avkrasnov@salutedevices.com \
--cc=bobby.eshleman@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kernel@sberdevices.ru \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®