From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 538AF274B23 for ; Thu, 7 May 2026 01:45:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778118317; cv=none; b=qO/Fo9PiqPFIiWD5r5v+DY9BgAt8DPYAQc73y62u6epo8codfYWfer3fh/G3mHIS0qsvjWL1pQedaVGPjslvHrYLLciSnXweU2Wf/QzRYXsU22aVgU5rwTpTQojE6KC1gAERJK2IgE+dtuJxLT223YCRVLkAvZfbgkUwLarcucY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778118317; c=relaxed/simple; bh=nn+VuoW/LzPu6eLuBwL/M3i+EzeG+u/cAb5jKSt+Pmw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=fcnaAbdSNMmPb6KI7hVOWDDvlOG5lKdJoHpjPl9l9SuUUf2agJUIDTkn6O/O8kKnmHKtMBgv6Mm79dL+gZUW9UYPkt7g5ZcHMZZjb/HMntX8XguH19K1Y0dfperKoO/kSwBi7bvcVVVjUnrJDimXBS5+8izdFFvB0pCn8lDDXRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PySSpYPo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=fxvET7Ud; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PySSpYPo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="fxvET7Ud" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778118315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nn+VuoW/LzPu6eLuBwL/M3i+EzeG+u/cAb5jKSt+Pmw=; b=PySSpYPof0aYb4R81Ae+CXxMvEyCbWie/uEPpUaTiPnqF7bh+jYPxP0B/6jLBNqPSwkpsg nbR9KPvCFSVVkxfYI9JvbxL6tbTtLKqy1p0Vue0simCHfpu1ZZTs2SWxHSbYx39tao/eBY zNg9Q0RtAqADo3u2cmP3oq59d+7EJCo= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-UjO0UgdJMNKkkW0JY3nT1w-1; Wed, 06 May 2026 21:45:14 -0400 X-MC-Unique: UjO0UgdJMNKkkW0JY3nT1w-1 X-Mimecast-MFC-AGG-ID: UjO0UgdJMNKkkW0JY3nT1w_1778118314 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50df4c130dbso12832271cf.1 for ; Wed, 06 May 2026 18:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778118314; x=1778723114; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=nn+VuoW/LzPu6eLuBwL/M3i+EzeG+u/cAb5jKSt+Pmw=; b=fxvET7UdQDWHaDZzrY3Zrrb/wyIqWIyMcdn9JAZEgEyxvRaXaS/+xln9nX1YMfaXRt zA7zvgb4K4BNxXbPTgzhiabR2CPwRO2hbVO6igaBHApg6sNQcg2XlQnPKXmFK8evedXK HwcYpTXTRN+WQIHGQj2drD2E4fuKRmbw1WkM99rq8+PVcmuiIT9CaFIygwCvecPL15Vq +RJxTk/37H6QtVNDrjLp/zBAT4WusMhoGK1R5Pj5CwMUwQnyr7TpL7iJ/YA7b81WMqRp nx/JNGpUNHQKhEj0wpO3U+g1HmehXqEOVsjidPVoVy/xNS0k2rGvXrYRL9I/gUWK2PfF mQtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778118314; x=1778723114; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nn+VuoW/LzPu6eLuBwL/M3i+EzeG+u/cAb5jKSt+Pmw=; b=nNn79IAhMR84anQSNAaMh+pT8A5y7cqrW8aatlDPS//RGAs4zloJhYh6DNr5atTT/G n9iF5qxOJAB6FFiaGCar8GC1ftPBkQrr8xWOfsveACYxYrdi7KjcBFUCMcZSBK3N339R OqFON2vk5mYoKQd/Lazxeu6Eph18iKpHySa+qI/fQzjcSBnAGXNVTC+Ne43EugfHmfyo NVumvOJO/l5PT5C41TEQjizJTf97RTnbrCGjndgsHz3Oeg7dxkYU/Tc6yZNqvrCMrmln 7+2jAnOgRaUWTH0ZARk/M3OKmeAcQinpM8DildfgTN1GILKfGENlakhYErUY6kl5LV/p C74w== X-Forwarded-Encrypted: i=1; AFNElJ9WXl9R++y795iy8QRNI98pgRXuGBUmbf8hY4c6Kx9OntU1HdSNmLeFnKZv4AY4Ts/VWMUAbCgg5Sp0k4U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5/sSDRhJmGAfyM+zj9q0D3ZmKIJsN4Inw68BKr98Lj0lS3AG4 fyt5KUtqmrzeX3RErjbihcsN1vZaVZVzLycMh0PIxtPqbcI4SRDpUx9tpg8syOMEL38nO7dhzDh o6cDASc8TKzxvDXjoepmt555u67WEKsmmLHZBqFenO4kGItfjAhCUdWtze0oVIKHFBw== X-Gm-Gg: AeBDievL4EWxewk7tkQjkW5xqTDndTLrRvGa5d9+61VVSf9tAH4507sbFPVjITYd1qb zRhJpPmnW0Sf7nUFYXk9olZDZCrmlehalRrNDgWP0rvKjdxorsEedUeOEuCQua+sbIgXLr2m0pn PBC3IPkZeFOnr7ZT8ZR7b9R8gHXZiM+AeXPjuzoc2QGuId9m7tk55AB+3Xexd9MekRlQBwAk18r 7dvsDfE4X+lQpbzwx59+xX7NfEiqMLS+5co+r0GZIq1efFLxpCiNVyWCUOenCB/iyqv2grUrBAD GhW6fyRodBVwzi+1k7/8mqzg9d/2HDSh4j1x+p1na7qY15RQXNxs6cGMyUX94IlYDUoHjawR28N F0i45UJyNT2tv6tvtCXvm9KPi2GjbG3wTwCVQJySJlSsbMZjde3mKW5/vCSkYtUQGf5sKqAhzKA qx2fM= X-Received: by 2002:a05:622a:5cd:b0:50f:c133:2dc6 with SMTP id d75a77b69052e-51475c0ff06mr12978391cf.19.1778118313463; Wed, 06 May 2026 18:45:13 -0700 (PDT) X-Received: by 2002:a05:622a:5cd:b0:50f:c133:2dc6 with SMTP id d75a77b69052e-51475c0ff06mr12978171cf.19.1778118312849; Wed, 06 May 2026 18:45:12 -0700 (PDT) Received: from loberman-thinkpadp16gen3.rmtusma.csb ([2600:6c65:2440:d8c:aa2b:ddff:fe88:da74]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51040908d6bsm163629391cf.7.2026.05.06.18.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 18:45:12 -0700 (PDT) Message-ID: <9b49bda9e8e3dce89eaf969f452ddd2315c2f953.camel@redhat.com> Subject: Re: [PATCH 0/2] scsi: smartpqi: fix PCIe hot reset recovery From: Laurence Oberman To: Mateusz Nowicki , don.brace@microchip.com Cc: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, storagedev@microchip.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 06 May 2026 21:45:11 -0400 In-Reply-To: <9624a8d152197522d353ef7bb2b4928d1c6238ae.camel@redhat.com> References: <9624a8d152197522d353ef7bb2b4928d1c6238ae.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-05-06 at 18:21 -0400, Laurence Oberman wrote: > On Wed, 2026-05-06 at 14:01 +0000, Mateusz Nowicki wrote: > > A PCIe bus reset (e.g. "echo 1 > /sys/bus/pci/devices//reset") > > on a > > controller without FLR support leaves the HPE SR932i-p Gen10+ > > unusable > > until reboot: smartpqi registers no pci_error_handlers, so the > > driver > > is not notified, firmware reverts to SIS mode, and all queue > > mappings > > are dropped while the driver still drives PQI. > >=20 > > Patch 1 adds .reset_prepare / .reset_done reusing > > pqi_ofa_ctrl_quiesce() / _unquiesce() / pqi_ctrl_init_resume(). > >=20 > > Patch 2 raises SIS_CTRL_READY_RESUME_TIMEOUT_SECS from 90s to 180s, > > matching the cold-boot path; without this patch 1 fails at the SIS > > ready check because firmware boot after reset takes ~125s on the > > SR932i-p Gen10+. > >=20 > > Tested on HPE SR932i-p Gen10+ against Linus' master at > > 74fe02ce122a. > >=20 > > Note: the From: header is my Posteo address because my employer's > > SMTP > > is unavailable for external mailing lists.=C2=A0 The Signed-off-by > > carries > > the Microchip attribution. > >=20 > > Mateusz Nowicki (2): > > =C2=A0 scsi: smartpqi: add pci_error_handlers for bus reset recovery > > =C2=A0 scsi: smartpqi: increase SIS ctrl ready resume timeout to 180s > >=20 > > =C2=A0drivers/scsi/smartpqi/smartpqi_init.c | 47 > > +++++++++++++++++++++++++++ > > =C2=A0drivers/scsi/smartpqi/smartpqi_sis.c=C2=A0 |=C2=A0 2 +- > > =C2=A02 files changed, 48 insertions(+), 1 deletion(-) > >=20 > > -- > > 2.43.0 > >=20 > >=20 > >=20 > Hello >=20 > I did reproduce this so I am testing the patches as well. > They look correct to me, I will reply again after testing with a > review. >=20 > Thanks > Laurence >=20 >=20 > [2513778.140012] smartpqi 0000:64:00.0: no heartbeat detected - last > heartbeat count: 4207808511 > [2513778.140031] smartpqi 0000:64:00.0: controller offline: reason > code > 0x4 (no controller heartbeat detected) > [2513778.141346] sd 1:0:0:0: [sda] tag#549 FAILED Result: > hostbyte=3DDID_NO_CONNECT driverbyte=3DDRIVER_OK cmd_age=3D18s > [2513778.141355] sd 1:0:0:0: [sda] tag#550 FAILED Result:=C2=A0 >=20 > "xfs_buf_ioend_handle_error+0xd5/0x3f0 [xfs]" at daddr 0x9f78 len 8 > error 5 > [2513778.141526] XFS (dm-0): log I/O error -5 >=20 Hello=20 For the series: I tested the patches and it recovers with them applied. The patches look good. Tested-by: Laurence Oberman Reviewed-by: Laurence Oberman