From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 35312A50 for ; Thu, 28 Mar 2024 16:30:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711643444; cv=none; b=PAS1gevvG2RAb5p9FUJomIi+UtA3e/ugEbbQfn16TNGpIdb2h5bTPWMq+y4TZheo7OipxzmuDcKl3Yrei0LveovWtgqE/Nr4PKPAZhyxTqKelbFPFEWt123nx7R+sEmG0uv2e3CxXlfWSKY6PYEMsotf9UpCgABb3dfXQApBt9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711643444; c=relaxed/simple; bh=HCcfQ7iZ8tF5ZRVSJpZsOLgQLzt9XPedqg23NKmb7nk=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=RJfsbs4eu4ZIfgzUSwyV+vjt0dUZsZEPJ+74qrcdtLfXniaDKz2gyxcPYxlk1nWU6oiES81cE1+HqOo2/jklFfh1hRDJmn0Ok/isFSIO/fZ4x5Iv9k6szmGeA5KVaHW6j7iBZy0ZNf0kcSHIVs3MM7k2BGFNwgD6+SX7tWr4GTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 132A81476; Thu, 28 Mar 2024 09:31:15 -0700 (PDT) Received: from [10.1.29.21] (e122027.cambridge.arm.com [10.1.29.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC09F3F694; Thu, 28 Mar 2024 09:30:39 -0700 (PDT) Message-ID: <9b4ac3de-21b2-4602-b96d-f51e8d4e6b14@arm.com> Date: Thu, 28 Mar 2024 16:30:39 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panfrost: fix power transition timeout warnings Content-Language: en-GB To: Christian Hewitt , Boris Brezillon , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20240322164525.2617508-1-christianshewitt@gmail.com> From: Steven Price In-Reply-To: <20240322164525.2617508-1-christianshewitt@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/03/2024 16:45, Christian Hewitt wrote: > Increase the timeout value to prevent system logs on Amlogic boards flooding > with power transition warnings: > > [ 13.047638] panfrost ffe40000.gpu: shader power transition timeout > [ 13.048674] panfrost ffe40000.gpu: l2 power transition timeout > [ 13.937324] panfrost ffe40000.gpu: shader power transition timeout > [ 13.938351] panfrost ffe40000.gpu: l2 power transition timeout > ... > [39829.506904] panfrost ffe40000.gpu: shader power transition timeout > [39829.507938] panfrost ffe40000.gpu: l2 power transition timeout > [39949.508369] panfrost ffe40000.gpu: shader power transition timeout > [39949.509405] panfrost ffe40000.gpu: l2 power transition timeout > > The 2000 value has been found through trial and error testing with devices > using G52 and G31 GPUs. > > Fixes: 22aa1a209018 ("drm/panfrost: Really power off GPU cores in panfrost_gpu_power_off()") > Signed-off-by: Christian Hewitt Queued to drm-misc-fixes. Thanks, Steve > --- > drivers/gpu/drm/panfrost/panfrost_gpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c > index 9063ce254642..fd8e44992184 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c > @@ -441,19 +441,19 @@ void panfrost_gpu_power_off(struct panfrost_device *pfdev) > > gpu_write(pfdev, SHADER_PWROFF_LO, pfdev->features.shader_present); > ret = readl_relaxed_poll_timeout(pfdev->iomem + SHADER_PWRTRANS_LO, > - val, !val, 1, 1000); > + val, !val, 1, 2000); > if (ret) > dev_err(pfdev->dev, "shader power transition timeout"); > > gpu_write(pfdev, TILER_PWROFF_LO, pfdev->features.tiler_present); > ret = readl_relaxed_poll_timeout(pfdev->iomem + TILER_PWRTRANS_LO, > - val, !val, 1, 1000); > + val, !val, 1, 2000); > if (ret) > dev_err(pfdev->dev, "tiler power transition timeout"); > > gpu_write(pfdev, L2_PWROFF_LO, pfdev->features.l2_present); > ret = readl_poll_timeout(pfdev->iomem + L2_PWRTRANS_LO, > - val, !val, 0, 1000); > + val, !val, 0, 2000); > if (ret) > dev_err(pfdev->dev, "l2 power transition timeout"); > }