From: Bart Van Assche <bvanassche@acm.org>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2] scsi: core: Add 'serial' sysfs attribute for SCSI/SATA
Date: Mon, 9 Feb 2026 12:27:42 -0800 [thread overview]
Message-ID: <9b4de8bc-273c-48c3-9c26-4055b2a5d306@acm.org> (raw)
In-Reply-To: <aYo2JBW76jH44lAU@google.com>
On 2/9/26 11:31 AM, Igor Pylypiv wrote:
> Instead, I will put a newline
> manually and return the correct number of characters. PAGE_SIZE is passed
> to scsi_vpd_lun_serial() so we don't sysfs_emit_at() to check it again.
>
> buf[ret] = '\n';
> return ret + 1;
This sounds good to me.
Thanks,
Bart.
prev parent reply other threads:[~2026-02-09 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 18:00 Igor Pylypiv
2026-02-09 17:31 ` Bart Van Assche
2026-02-09 19:31 ` Igor Pylypiv
2026-02-09 20:27 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b4de8bc-273c-48c3-9c26-4055b2a5d306@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=ipylypiv@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®