mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Yusuf Khan <yusisamerican@gmail.com>,
	linux-kernel@vger.kernel.org, jasowang@redhat.com,
	mikelley@microsoft.com, mst@redhat.com, javier@javigon.com,
	arnd@arndb.de, will@kernel.org, axboe@kernel.dk
Subject: Re: [PATCH v7] drivers: ddcci: upstream DDCCI driver
Date: Fri, 11 Mar 2022 03:16:22 -0800	[thread overview]
Message-ID: <9b4e3cda7f5e8b630437cfc101f72810bc3f8d46.camel@perches.com> (raw)
In-Reply-To: <Yisr7WH+EfEhMbVY@kroah.com>

On Fri, 2022-03-11 at 12:01 +0100, Greg KH wrote:
> On Fri, Mar 11, 2022 at 02:45:01AM -0800, Joe Perches wrote:
> > On Fri, 2022-03-11 at 09:14 +0100, Greg KH wrote:
> > > On Thu, Mar 10, 2022 at 11:44:13PM -0800, Yusuf Khan wrote:
> > > > This patch upstreams the DDCCI driver by Christoph Grenz into
> > > > the kernel. The original gitlab page is loacted at https://gitlab
> > > > .com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
> > []
> > > > diff --git a/drivers/char/ddcci.c b/drivers/char/ddcci.c
> > []
> > > > @@ -0,0 +1,1887 @@
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > > +/*
> > > > + *  DDC/CI sub-bus driver
> > > > + *
> > > > + *  Copyright (c) 2015 Christoph Grenz
> > > > + */
> > > > +
> > > > +/*
> > > > + * This program is free software; you can redistribute it and/or modify it
> > > > + * under the terms of the GNU General Public License as published by the Free
> > > > + * Software Foundation; either version 2 of the License, or (at your option)
> > > > + * any later version.
> > > 
> > > This does not match the SPDX line.  Please fix up first before going any
> > > further.
> > 
> > Which means fix up the SPDX line above to use the actual
> > license of the code.
> > 
> > // SPDX-License-Identifier: GPL-2.0-or-later
> 
> If that is the intent, it depends on the original author, I have not
> seen the source for where this came from, have you?

Tes.

Just take 10 seconds to look at the link provided in the text above
before you take 10 seconds to ask me instead.

https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master

And it's a bit odd of you to suggest otherwise when the link is
clearly shown and the actual license text is clear with
"(at your option) any later version".



  reply	other threads:[~2022-03-11 11:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  7:44 Yusuf Khan
2022-03-11  8:14 ` Greg KH
2022-03-11 10:45   ` Joe Perches
2022-03-11 11:01     ` Greg KH
2022-03-11 11:16       ` Joe Perches [this message]
2022-03-12  5:09   ` Yusuf Khan
2022-03-12  6:31     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b4e3cda7f5e8b630437cfc101f72810bc3f8d46.camel@perches.com \
    --to=joe@perches.com \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=javier@javigon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=mst@redhat.com \
    --cc=will@kernel.org \
    --cc=yusisamerican@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®