From: Casey Schaufler <casey@schaufler-ca.com>
To: Michal Orzel <michalorzel.eng@gmail.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH 5/5] smack: Remove redundant assignments
Date: Thu, 31 Mar 2022 11:44:19 -0700 [thread overview]
Message-ID: <9b521078-5809-7c59-9c58-b71ee406ee29@schaufler-ca.com> (raw)
In-Reply-To: <20220331173358.40939-5-michalorzel.eng@gmail.com>
On 3/31/2022 10:33 AM, Michal Orzel wrote:
> Get rid of redundant assignments which end up in values not being
> read either because they are overwritten or the function ends.
>
> Reported by clang-tidy [deadcode.DeadStores]
>
> Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Thank you. I will take this via the Smack tree.
> ---
> security/smack/smackfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 658eab05599e..9e61014073cc 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -1192,7 +1192,6 @@ static ssize_t smk_write_net4addr(struct file *file, const char __user *buf,
> rc = -EINVAL;
> goto free_out;
> }
> - m = BEBITS;
> masks = 32;
> }
> if (masks > BEBITS) {
prev parent reply other threads:[~2022-03-31 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 17:33 [PATCH 1/5] apparmor: " Michal Orzel
2022-03-31 17:33 ` [PATCH 2/5] integrity: " Michal Orzel
2022-03-31 17:33 ` [PATCH 3/5] keys: " Michal Orzel
2022-04-03 8:06 ` Jarkko Sakkinen
2022-03-31 17:33 ` [PATCH 4/5] selinux: " Michal Orzel
2022-03-31 17:33 ` [PATCH 5/5] smack: " Michal Orzel
2022-03-31 18:44 ` Casey Schaufler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b521078-5809-7c59-9c58-b71ee406ee29@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=michalorzel.eng@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®