From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9472BEE57D0 for ; Fri, 8 Sep 2023 05:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235022AbjIHF4G (ORCPT ); Fri, 8 Sep 2023 01:56:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbjIHF4E (ORCPT ); Fri, 8 Sep 2023 01:56:04 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 084D519BA; Thu, 7 Sep 2023 22:55:59 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A5A4F1F749; Fri, 8 Sep 2023 05:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694152558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QQhkJAyeX2RFjNddtb7bnQt1fhTJYz1Tq51AB0Z0tqs=; b=xPAh9iPGzZnnKb0A2UugQwYTTMD2+nZv2GtmUPEceRRuvQTR+G/fPH/4GqvhjVXMRVzrhe RCt4hrXtnb7tr/M1wqMAtdjlz08Zi0cyyN9EgvzC3rBz6QA8haZxX60mdLsCBGDL289l7U gt31cy5JlR8TAz6bOmgxy1EvgI5jL34= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694152558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QQhkJAyeX2RFjNddtb7bnQt1fhTJYz1Tq51AB0Z0tqs=; b=7d0pBCEKDR0+2TM2hweNW7CefzSWRB1yKDUt2QWSK+Wn99P/7tXcs9r56lvXQyfdpvMkm1 HL5FiKiLWSjHKwAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2DE78131FD; Fri, 8 Sep 2023 05:55:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EJUhCm63+mSyZAAAMHmgww (envelope-from ); Fri, 08 Sep 2023 05:55:58 +0000 Message-ID: <9b524f00-35f1-4f6c-896e-40f2879040d2@suse.de> Date: Fri, 8 Sep 2023 07:55:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 03/12] block: add copy offload support Content-Language: en-US To: Nitesh Shetty Cc: Jens Axboe , Jonathan Corbet , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Alexander Viro , Christian Brauner , martin.petersen@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com, Anuj Gupta , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org References: <20230906163844.18754-1-nj.shetty@samsung.com> <20230906163844.18754-4-nj.shetty@samsung.com> <20230907071611.rgukw7fory2xh5sy@green245> From: Hannes Reinecke In-Reply-To: <20230907071611.rgukw7fory2xh5sy@green245> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/23 09:16, Nitesh Shetty wrote: > On 07/09/23 07:49AM, Hannes Reinecke wrote: >> On 9/6/23 18:38, Nitesh Shetty wrote: >> >> Hmm. That looks a bit odd. Why do you have to use wait_for_completion? > > wait_for_completion is waiting for all the copy IOs to complete, > when caller does not pass endio handler. > Copy IO submissions are still async, as in previous revisions. > >> Can't you submit the 'src' bio, and then submit the 'dst' bio from the >> endio handler of the 'src' bio? > We can't do this with the current bio merging approach. > 'src' bio waits for the 'dst' bio to arrive in request layer. > Note that both bio's should be present in request reaching the driver, > to form the copy-cmd. > Hmm. I guess it would be possible, but in the end we can always change it later once the infrastructure is in. So: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman