From: YueHaibing <yuehaibing@huawei.com>
To: Russell Currey <ruscur@russell.cc>, <paulus@samba.org>,
<mpe@ellerman.id.au>, <mahesh@linux.vnet.ibm.com>,
<npiggin@gmail.com>, <ganeshgr@linux.ibm.com>, <anton@samba.org>
Cc: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()
Date: Wed, 24 Apr 2019 09:48:20 +0800 [thread overview]
Message-ID: <9b540ba8-9711-f4a2-b4bc-d35a05fd3dda@huawei.com> (raw)
In-Reply-To: <1b208e33c4f51630e2a336e95f25509fe7286e34.camel@russell.cc>
On 2019/4/24 9:29, Russell Currey wrote:
> On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> rtas_parse_epow_errlog() should pass 'modifier' to
>> handle_system_shutdown, because event modifier only use
>> bottom 4 bits.
>>
>> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
>> interrupts")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Hello,
>
> This fails to compile.
>
> arch/powerpc/platforms/pseries/ras.c: In function
> 'rtas_parse_epow_errlog':
> arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
> undeclared (first use in this function); did you mean 'modifier'?
> handle_system_shutdown(event_modifier);
> ^~~~~~~~~~~~~~
> modifier
Yes, this should be 'modifier'
>
> So yes, I assume you meant "modifier" instead of "event_modifier" as
> mentioned in your commit message. Did you compile this before sending?
I am very sorry for this, this is not my compiled version,
I forgot to check again before sending.
>
> (found by snowpatch)
>
> - Russell
>
>
> .
>
next prev parent reply other threads:[~2019-04-24 1:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 14:35 Yue Haibing
2019-04-24 1:29 ` Russell Currey
2019-04-24 1:48 ` YueHaibing [this message]
2019-04-24 2:17 ` [PATCH v2] " Yue Haibing
2019-04-25 22:17 ` Tyrel Datwyler
2019-05-30 15:00 ` Yuehaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b540ba8-9711-f4a2-b4bc-d35a05fd3dda@huawei.com \
--to=yuehaibing@huawei.com \
--cc=anton@samba.org \
--cc=ganeshgr@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®