mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
	Qing Wang <wangqing@vivo.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: da9150: use div64_u64() instead of do_div()
Date: Fri, 11 Feb 2022 21:53:08 +0100	[thread overview]
Message-ID: <9b563415-f58a-15f1-b375-64ef4e98ca05@wanadoo.fr> (raw)
In-Reply-To: <20220211205026.6jhtt66wco5ht6i6@mercury.elektranox.org>

Le 11/02/2022 à 21:50, Sebastian Reichel a écrit :
> Hi,
> 
> On Wed, Feb 09, 2022 at 12:39:46AM -0800, Qing Wang wrote:
>> From: Wang Qing <wangqing@vivo.com>
>>
>> do_div() does a 64-by-32 division.
>> When the divisor is u64, do_div() truncates it to 32 bits, this means it
>> can test non-zero and be truncated to zero for division.
>>
>> fix do_div.cocci warning:
>> do_div() does a 64-by-32 division, please consider using div64_u64 instead.
>>
>> Signed-off-by: Wang Qing <wangqing@vivo.com>
>> ---
> 
> Thanks, queued.

All these patches are broken and should be NACKed, fixed or reverted if 
applied.

See [1].

CJ

[1]: 
https://lore.kernel.org/linux-kernel/19b96972-cee7-937f-21ce-c78982ed2048@linaro.org/

> 
> -- Sebastian
> 
>>   drivers/power/supply/da9150-fg.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
>> index 6e36782..896491a
>> --- a/drivers/power/supply/da9150-fg.c
>> +++ b/drivers/power/supply/da9150-fg.c
>> @@ -250,7 +250,7 @@ static int da9150_fg_current_avg(struct da9150_fg *fg,
>>   	div = (u64) (sd_gain * shunt_val * 65536ULL);
>>   	do_div(div, 1000000);
>>   	res = (u64) (iavg * 1000000ULL);
>> -	do_div(res, div);
>> +	div64_u64(res, div);
>>   
>>   	val->intval = (int) res;
>>   
>> -- 
>> 2.7.4
>>


  reply	other threads:[~2022-02-11 20:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09  8:39 Qing Wang
2022-02-11 20:50 ` Sebastian Reichel
2022-02-11 20:53   ` Christophe JAILLET [this message]
2022-02-11 21:40     ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b563415-f58a-15f1-b375-64ef4e98ca05@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=support.opensource@diasemi.com \
    --cc=wangqing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®