From: "Lillian Berry" <lillian@star-ark.net>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, "Al Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2] init/main.c: add warning when file specified in rdinit is inaccessible
Date: Mon, 07 Jul 2025 03:47:14 -0400 [thread overview]
Message-ID: <9b5b233a-762d-4961-9c9a-8bbf4b67d3d5@app.fastmail.com> (raw)
In-Reply-To: <20250706153239.3be93aee4b0c8d43e025bd85@linux-foundation.org>
On Sun, Jul 6, 2025, at 6:32 PM, Andrew Morton wrote:
>> + if (ramdisk_command_access != 0) {
>> + pr_warn("rdinit=%s is inaccessible or does not exist (errno %i), ignoring\n",
>> + ramdisk_execute_command, ramdisk_command_access);
>
> Again, I don't think we should assume (or say) "inaccessible or does not
> exist". After all, init_eaccess() could have returned -ENOMEM.
> Something like "access(%s) failed: %d", maybe.
Sorry, I must've misunderstood your previous mail. I'll change the
message to be more generic.
Kindly,
Lillian
prev parent reply other threads:[~2025-07-07 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 20:57 Lillian Berry
2025-07-06 22:32 ` Andrew Morton
2025-07-07 7:47 ` Lillian Berry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b5b233a-762d-4961-9c9a-8bbf4b67d3d5@app.fastmail.com \
--to=lillian@star-ark.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®