From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BF063D3D00 for ; Tue, 23 Jun 2026 11:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782214827; cv=none; b=qBUy0NmhOY73FX+CGEhzgWjMLSFxYZKfZDS29Ho/6FrZ5yA6arE42GlQpQq5Jq7tgYRE8jM0XeuGefAYelrcSDXVBfjOVvCQ12gl/ufwaYPEyPsQTw1v6F3zRJIRCFkNhcMO/r1XiCK19XIy4r9qST6sYaG6eDjwld2/ZAJ3RCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782214827; c=relaxed/simple; bh=cU4q+dAxzjz/DdxxWO6hFG4V0bYZzbvaND34NUZu7PI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QFUOr9yR0CxIQGDU/NGoVYTKkJQwtVHO83uEQ35cTCMpDYiH24iWcK8hL6up2g7LPFT3twFGoEYzsh0V08i2wipcC7ELdF0du/qMGXCBP4NSKqZiVua5/Xc8RzmYU+boNd04Wm4TfgOi2zQDV+CvE+Xa6f1KvCPQCa2L7BbQqdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FsMbsDLm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FkgfMrfX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FsMbsDLm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FkgfMrfX" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBXTiV3744680 for ; Tue, 23 Jun 2026 11:40:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3gbpIZDM+t+BqRGRuIADnoesPyoKgyGdyq6Z6YoV5lU=; b=FsMbsDLmantxocyn GDmJ0rr0zG+63KJzsBAVKtuY84dmLWjSvC0jgE3gzbeE7d6qwHEqYz4OtYrV8USp akVXYilcHHwAZZdlALHByn6Q74s9ywJeorYQtaeq18OVTyVuFuVd2gL93TPOJnWS 5gUysLPiYiie6A10Jwpm8WheWus3ILiRTz2XoPoMoOSOaIEkipFBfj9Zk0oEpDkx DQzsPZMl7Hrdjpw2SJ64s/fJX60/Zi94k250/v2aA9OA9KUF2mXYf6HLM+Kt0Pxh WILOyBVEyH8GHmVrNJO86tagACKzrX/OjJQlTiNOgeAPO/OKInCcxGwROj5qAFGo el++zw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eypx38r89-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:40:25 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9158e75cbc0so906571185a.2 for ; Tue, 23 Jun 2026 04:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782214824; x=1782819624; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3gbpIZDM+t+BqRGRuIADnoesPyoKgyGdyq6Z6YoV5lU=; b=FkgfMrfXIJ4TAP6T6ffpJlyM6Hk459ulSsIWSbfUXLpusQJhrT04lzUBvzRO2NANxl tciCRbiKfTaD3HLASUQe+nyI8936NWW4LTpQMEwgIxCn1jts4n2YWH3aDibDjsKzwYIf ksWiyw4EiqiWju2dye2ZVC1HLvgDacq29DxP3o6EH9SQ8v8XRyuuozCUTactQAMpAnv5 d1AKAhTTT15li6mVqVi/+So4YoT+lMdC62FeGy5Nei3TyU2b4sGCVxLrqrFIMyFZhX38 HZ2Sgjn6s6CdvIUDdKO8hxB5+Q1KbGHnh13RI5wLr9WkOrWeWgMTcS+NpAAQwRTZ/058 u2nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782214824; x=1782819624; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3gbpIZDM+t+BqRGRuIADnoesPyoKgyGdyq6Z6YoV5lU=; b=TqEWvHbuVLS/92ixcjIgK9Qx/+24RIzlBroZGASRvvtT7q7ydi2qwsYRK/9DzLvXxl VYQsxjLWZHm/gfFWk3VTL+8tVzAKWXzpMY1wgOsMo+TZDnn6BHDS/kA4kKfe0iOZiAcJ iBNIlP0WfBp38j86v1CegJySTUvyKoAqQVA/rstJmGTJmUTqXZVBL/+ri85WgDLpcd5Y ZbXmTcIog2NT1Bo8BfSv946AwGHODIcRD9sd0XU7cdq460WIWCD8s/EF/itTqxaPYGg4 hBkP0T0BtelM7/1WotqAqrbcB2Guy9iH5v9fSzyhay4nxnClWrK/U3WDEyVWamlgmQn/ RE2w== X-Forwarded-Encrypted: i=1; AFNElJ9DZ9NRhIUIHnbW8Cz8aI5YzK6CGiuOni7cm0BQfaOfXXXY0IjOfmlkufONz0IwQmpVAvRiOorOcv7au/U=@vger.kernel.org X-Gm-Message-State: AOJu0Yyz6kl9FGBICjG3fvpCw1m/OKUZZY0d4hu+TWptqgWk5waDdseW CSqdPWtFLTx3kvLdATUU6OWGcjfd5M/Hbw0B2ZuxoDoUG8logkq4/Gr7ZnO+6v5AXTmoRG/wViR M2oS0o6TvWkUU5+wvGhQAqy/saiZsnsrqkDNlzObI+P1B2oN74QWi0I3F+xOZRb+JNcU= X-Gm-Gg: AfdE7ckXJdn0TdB2PRc/QxcZbklmwPrG5RijAzz4Sp0ERBtvCMDzGnv1EK3gGS/m8Kt t+kQ46FryjmVy3d0fWhj3sh4ahH5z7tLcHisMLP/YkLtwFArkpxflfpBydunvKyMnbZi4nPznql iIPQbXWjyE2jHF/P8BTRjACQErKvvD6bNctyk9AYIxf5rJOFXUcCWT5wuL0KUr+gudV+aSHeqXw nnhCxHmSd2B8ydoDnATZhBEMq97jyOiRbe3hhCKJSx11zfYhp5wksleShL0ThQGnT1jMyzAvoVt V/TkKFZefhVT+Xjng+5U4BJ9V3/R7bShnMas6e6H2OSfnjBMnhA/dtE1A4ogrBzOH3JiezXCSbb RCYBi2GcbXmDHnajLSrWIbKnAa4VNAo0P/Vi+c6WlZimy8OgPqZ/F1Qz8B9d9uEp0VNawqixTVQ == X-Received: by 2002:a05:620a:2616:b0:914:babf:9f45 with SMTP id af79cd13be357-92646583c1cmr430163085a.26.1782214824545; Tue, 23 Jun 2026 04:40:24 -0700 (PDT) X-Received: by 2002:a05:620a:2616:b0:914:babf:9f45 with SMTP id af79cd13be357-92646583c1cmr430156385a.26.1782214824036; Tue, 23 Jun 2026 04:40:24 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:21db:9254:19d9:645e? ([2a05:6e02:1041:c10:21db:9254:19d9:645e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46666788226sm34668027f8f.23.2026.06.23.04.40.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 04:40:23 -0700 (PDT) Message-ID: <9b5ea951-6880-4ce8-8764-fd6bf2bd57a0@oss.qualcomm.com> Date: Tue, 23 Jun 2026 13:40:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kernel/cpu: Disallow offlining boot CPU based on config To: Sneh Mankad , Thomas Gleixner , Peter Zijlstra , "Rafael J. Wysocki" , Pavel Machek , Len Brown Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20260605-disable_boot_cpu_offline-v1-1-4c68fe1a6cf8@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260605-disable_boot_cpu_offline-v1-1-4c68fe1a6cf8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=EsfiaycA c=1 sm=1 tr=0 ts=6a3a70a9 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=W5qrNhqdD0BlkYEQxcQA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: Iw96F0ON0wxhJVR20ndAsCvugXXrDkhL X-Proofpoint-GUID: Iw96F0ON0wxhJVR20ndAsCvugXXrDkhL X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA5NCBTYWx0ZWRfXyLq3WvGOWbdK 9N37zDu55Z2IpK9p1Vs4GmHczDUEM5eGPliR5enxdQBK5iXnacIi8h3SOL4GUIxhTsUYzUeIfGu GWwl75HP7exuEMp7/+eLwFmjo9Vk2oA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA5NCBTYWx0ZWRfX7Ilg0RLSrNgm SO6/2TjMJFGpHXqhWKZfg5mmomhkgyiJXg6XMXyxTz4wp66PvK+j0lUojE7asFz2+slQGzeEH9z TQ2QlbS0ZbCeoHU8EFgWSrPWtx4FjjOQzN/v37p6QkeUVpVyfB9e/ZTAKAgMyggLchNPi8EOlfw KYqEd3qdGSYuzfYBcWSBtyfIJ5owjvhVx5kylj1aPrXZmz648LKKnSkUV8so8WAWnlibiVCTNpv D66Ycn4/mcsZDd4PKUmcKyB4PigkenqJ/KvteF8rEboeDTRl4gaqUEAasRGQQ4t/uQKl9yHxztS uiGQ6zoq/Kk4FpraZWiK+Csw8EC7TQ6a1BEGX84LUYmXHLTdIKSpRaovGsAJAA+dxdSy9I+L+iQ jZyHAMeBtnA604FWeokSA2771RMiJ7NhvWQxaeYjZxnjX5BqLrnyM9vRE/ydz7JK15yW/bkd3nr 3KfCJX6IT9kBi0lwz4g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230094 Hi Sned, On 6/5/26 12:30, Sneh Mankad wrote: > The Qualcomm SoCs like LeMans, Monaco support suspend to ram which leads > the SoC to ACPI S3 similar state where SoC is turned off and DDR is > retained. > The hardware design on these SoCs forces a constraint to suspend and > resume the system on boot CPU / CPU0. > > If CPU0 is already offline before starting suspend to ram the > freeze_secondary_cpus() picks alternate CPU as primary / last CPU and > proceed further to invoke PSCI SYSTEM_SUSPEND. > This leads to a system crash. > > In order to prevent such an issue introduce PM_SLEEP_SMP_CPU_ZERO_STRICT > config and when enabled prohibit the CPU0 to be offline. What is the status of this change ? Are you planning to send a new version with the check inside arch_cpu_is_hotpluggable() ? > Signed-off-by: Sneh Mankad > --- > kernel/cpu.c | 4 ++++ > kernel/power/Kconfig | 8 ++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/kernel/cpu.c b/kernel/cpu.c > index bc4f7a9ba64e62d76fbb2b362f243c918defe5bc..1c878db1d9cb6df0e31cb55343851aab4e38a3a0 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -1478,6 +1478,10 @@ static int cpu_down_maps_locked(unsigned int cpu, enum cpuhp_state target) > */ > if (cpu_hotplug_offline_disabled) > return -EOPNOTSUPP; > +#ifdef CONFIG_PM_SLEEP_SMP_CPU_ZERO_STRICT > + if (cpu == get_boot_cpu_id()) > + return -EPERM; > +#endif > if (cpu_hotplug_disabled) > return -EBUSY; > return _cpu_down(cpu, 0, target); > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig > index 05337f437cca29da57864583166d7f9abd526507..0b342b3a4a5650a1927dc4805d1515e1d9e067c6 100644 > --- a/kernel/power/Kconfig > +++ b/kernel/power/Kconfig > @@ -401,3 +401,11 @@ config ENERGY_MODEL > The exact usage of the energy model is subsystem-dependent. > > If in doubt, say N. > + > +config PM_SLEEP_SMP_CPU_ZERO_STRICT > + bool "Disallow boot CPU (CPU0) offline" > + depends on HOTPLUG_CPU > + depends on SUSPEND > + help > + Disallow boot CPU (CPU0) offline when the suspend_ops->enter() > + has to be executed by boot CPU. > > --- > base-commit: ba3e43a9e601636f5edb54e259a74f96ca3b8fd8 > change-id: 20260603-disable_boot_cpu_offline-eb4f55ac96f2 > > Best regards,