From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756621AbdJJXTt (ORCPT ); Tue, 10 Oct 2017 19:19:49 -0400 Received: from sonic310-29.consmr.mail.ne1.yahoo.com ([66.163.186.210]:35281 "EHLO sonic310-29.consmr.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754477AbdJJXTr (ORCPT ); Tue, 10 Oct 2017 19:19:47 -0400 X-YMail-OSG: _XDJSNMVM1ne8sKTgSpc1.tQYYeucUV2_XM4WnmchFki_fgRih0Ztn2o8EKGzX_ 4TlnLDAxlgBkvIig87jFctSvRUUjtk0CqrlBS4mJmNfryV.ZAXngArXaukQ3LuX3c0yzW7RSyNRw T8HndzIu36pI8odtb28DZ.XQjop9vHQyWQwnEl4R4NNbxsWgQpab8JP7gLEDQt1c.kMRoo5oaYuI IIJERV4FQAgPst82RUL3GZmRYfefM1DhuNaI8Mi9OSRLrKV_CdIq3_LV3jJ.lmnaFv8_94tCHDIk jJ9F92wZhAlN19J6.72thAE_hOoRHWKcaAL8LGo1..BkJ7a9Wr5l1pZ2GnNJ5fQ4PP5eQx3C3wQ1 VvIpQnAxgFTCCcM6BBWccvBxcw_hR3TUHXhYajPejgGT3uOV_vqQ7Yn8V24kT2H_PrHfYVb5ZFZH pEZZUW3a5d52_ynX4WRKWCi25LYqEvLfiLJ.Ca5Q.nYs_sY.hHYVj79y.hDka.grmZ_h5d1Ma3gv OhoVz4yZFDPThp8q4ls3Pn7zO6w-- X-Yahoo-Newman-Id: 898454.51875.bm@smtp203.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: _XDJSNMVM1ne8sKTgSpc1.tQYYeucUV2_XM4WnmchFki_fg Rih0Ztn2o8EKGzX_4TlnLDAxlgBkvIig87jFctSvRUUjtk0CqrlBS4mJmNfr yV.ZAXngArXaukQ3LuX3c0yzW7RSyNRwT8HndzIu36pI8odtb28DZ.XQjop9 vHQyWQwnEl4R4NNbxsWgQpab8JP7gLEDQt1c.kMRoo5oaYuIIIJERV4FQAgP st82RUL3GZmRYfefM1DhuNaI8Mi9OSRLrKV_CdIq3_LV3jJ.lmnaFv8_94tC HDIkjJ9F92wZhAlN19J6.72thAE_hOoRHWKcaAL8LGo1..BkJ7a9Wr5l1pZ2 GnNJ5fQ4PP5eQx3C3wQ1VvIpQnAxgFTCCcM6BBWccvBxcw_hR3TUHXhYajPe jgGT3uOV_vqQ7Yn8V24kT2H_PrHfYVb5ZFZHpEZZUW3a5d52_ynX4WRKWCi2 5LYqEvLfiLJ.Ca5Q.nYs_sY.hHYVj79y.hDka.grmZ_h5d1Ma3gvOhoVz4yZ FDPThp8q4ls3Pn7zO6w-- X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw-- Subject: Re: [PATCH] selinux: Fix bool initialization/comparison To: Thomas Meyer , paul@paul-moore.com, sds@tycho.nsa.gov, eparis@parisplace.org, james.l.morris@oracle.com, serge@hallyn.com, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <1507383097081-778026979-0-diffsplit-thomas@m3y3r.de> <1507383097088-1068794175-19-diffsplit-thomas@m3y3r.de> From: Casey Schaufler Message-ID: <9b5f9458-ac5f-621b-ff0c-677de365c216@schaufler-ca.com> Date: Tue, 10 Oct 2017 16:19:46 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507383097088-1068794175-19-diffsplit-thomas@m3y3r.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/2017 7:02 AM, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c > --- a/security/selinux/ss/mls.c > +++ b/security/selinux/ss/mls.c > @@ -550,7 +550,7 @@ int mls_compute_sid(struct context *scon > > /* Fallthrough */ > case AVTAB_CHANGE: > - if ((tclass == policydb.process_class) || (sock == true)) > + if ((tclass == policydb.process_class) || (sock)) How about + if ((tclass == policydb.process_class) || sock) > /* Use the process MLS attributes. */ > return mls_context_cpy(newcontext, scontext); > else > diff -u -p a/security/selinux/ss/services.c b/security/selinux/ss/services.c > --- a/security/selinux/ss/services.c > +++ b/security/selinux/ss/services.c > @@ -1656,7 +1656,7 @@ static int security_compute_sid(u32 ssid > } else if (cladatum && cladatum->default_role == DEFAULT_TARGET) { > newcontext.role = tcontext->role; > } else { > - if ((tclass == policydb.process_class) || (sock == true)) > + if ((tclass == policydb.process_class) || (sock)) Excessive () > newcontext.role = scontext->role; > else > newcontext.role = OBJECT_R_VAL; > @@ -1668,7 +1668,7 @@ static int security_compute_sid(u32 ssid > } else if (cladatum && cladatum->default_type == DEFAULT_TARGET) { > newcontext.type = tcontext->type; > } else { > - if ((tclass == policydb.process_class) || (sock == true)) { > + if ((tclass == policydb.process_class) || (sock)) { Excessive () > /* Use the type of process. */ > newcontext.type = scontext->type; > } else { >