From: David Lechner <david@lechnology.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"William Breathitt Gray" <william.gray@linaro.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 2/2] counter: ti-eqep: Convert to platform remove callback returning void
Date: Mon, 11 Mar 2024 08:57:42 -0500 [thread overview]
Message-ID: <9b61b7cd-38c6-456b-aef1-be96c6bff978@lechnology.com> (raw)
In-Reply-To: <bf78595f6a49be0b6bb403b466c13177d72c02b7.1710057753.git.u.kleine-koenig@pengutronix.de>
On 3/10/24 3:06 AM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Acked-by: David Lechner <david@lechnology.com>
next prev parent reply other threads:[~2024-03-11 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 8:06 [PATCH 0/2] counter: " Uwe Kleine-König
2024-03-10 8:06 ` [PATCH 1/2] counter: ti-ecap-capture: " Uwe Kleine-König
2024-03-10 8:06 ` [PATCH 2/2] counter: ti-eqep: " Uwe Kleine-König
2024-03-11 13:57 ` David Lechner [this message]
2024-03-18 14:42 ` [PATCH 0/2] counter: " wbg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b61b7cd-38c6-456b-aef1-be96c6bff978@lechnology.com \
--to=david@lechnology.com \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®