From: Marek Vasut <marex@denx.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Richard Leitner <richard.leitner@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: mike.looijmans@topic.nl
Subject: Re: [PATCH] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32
Date: Mon, 15 May 2023 14:55:47 +0200 [thread overview]
Message-ID: <9b62a0db-1374-2c89-5ea3-286467bd1e4e@denx.de> (raw)
In-Reply-To: <20230515103337.130607-1-krzysztof.kozlowski@linaro.org>
On 5/15/23 12:33, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linuxx driver expects uint32. Fix the type to match Linux
Linux , one x too many .
> driver expectation and original binding.
>
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: mike.looijmans@topic.nl
> ---
> Documentation/devicetree/bindings/usb/usb251xb.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/usb251xb.yaml b/Documentation/devicetree/bindings/usb/usb251xb.yaml
> index 4d1530816817..ac5b99710332 100644
> --- a/Documentation/devicetree/bindings/usb/usb251xb.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml
> @@ -231,7 +231,7 @@ properties:
> power-on sequence to a port until the port has adequate power.
>
> swap-dx-lanes:
> - $ref: /schemas/types.yaml#/definitions/uint8-array
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> description: |
> Specifies the ports which will swap the differential-pair (D+/D-),
> default is not-swapped.
Would it make more sense to update the driver instead ? I doubt you
could have more than 256 ports on this device after all.
next prev parent reply other threads:[~2023-05-15 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 10:33 Krzysztof Kozlowski
2023-05-15 12:55 ` Marek Vasut [this message]
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.ed9c8f5a-900b-42eb-a8c2-543ccf3145e3@emailsignatures365.codetwo.com>
2023-05-15 13:17 ` mike.looijmans
2023-05-15 13:47 ` Marek Vasut
2023-05-16 8:19 ` Krzysztof Kozlowski
2023-05-16 8:21 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b62a0db-1374-2c89-5ea3-286467bd1e4e@denx.de \
--to=marex@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=richard.leitner@linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®